From nobody Sat Sep 20 10:34:45 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTQjm63vNz68cfM for ; Sat, 20 Sep 2025 10:34:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTQjm3Xq4z46Ww for ; Sat, 20 Sep 2025 10:34:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id zhZ2uwf3r0ym7zuvbu5xXH; Sat, 20 Sep 2025 10:34:51 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id zuvZuxMgRl5eGzuvauIpd0; Sat, 20 Sep 2025 10:34:51 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=EO6l0EZC c=1 sm=1 tr=0 ts=68ce834b a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=w1YJ_1iLAAAA:8 a=YxBL1-UpAAAA:8 a=4KQEnK0S3Mt5PXbqSG8A:9 a=QEXdDO2ut3YA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=zRPabYEqsVoUeGZq4nLW:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from ehlo.thunderbird.net (walden_pont_ng.cwsent.com [70.66.136.190]) by spqr.komquats.com (Postfix) with ESMTPSA id C02B389D; Sat, 20 Sep 2025 03:34:48 -0700 (PDT) Date: Sat, 20 Sep 2025 03:34:45 -0700 From: Cy Schubert To: freebsd-current@freebsd.org, Darrin Smith Subject: Re: Possible incompatible change with initgroups(3)? In-Reply-To: <20250920084357.32586ee5@darrin.worldsmith.org> References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> <20250920084357.32586ee5@darrin.worldsmith.org> Message-ID: <4215EA85-106C-42E4-B6B1-39507CF06729@cschubert.com> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CMAE-Envelope: MS4xfF0oQQhiX/UReHW6Bl1zzFQ2CcPTWjXgaE7ocmG9cvylSdyRVP9EfWiwLam4dKZOHdP+cPRTVWEW4kiNdtyEKZKPlxQ/qa5bqp0/yYD28lw/dZJCPTa6 ZzVEsHoSbpXZrq0PJSLOkSAhV39UTGV816Z0QQ2YCXG+t5Ex2HULhRNcN7b5tJvr3XEgR7MpMyrUacqglJqSt+E+Yx36uVFeBYzHvSrR4QX29ilnjKo0wqjh oe6J2sh24J2GdisouS+eBw== X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cTQjm3Xq4z46Ww On September 19, 2025 4:13:57=E2=80=AFp=2Em=2E PDT, Darrin Smith wrote: >On Sat, 20 Sep 2025 08:02:48 +0900 (JST) >Yasuhiro Kimura wrote: > >> Today I updated my 16=2E0-CURRENT amd64 system from >> main-n280279-b0e7b55a0e90 to main-n280498-b3468202994f and noticed >> Postfix emits such error messages as below=2E >>=20 >> ---------------------------------------------------------------------- >> Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: fatal: >> initgroups: Socket operation on non-socket Sep 20 03:00:11 >> rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgroups: Socket >> operation on non-socket Sep 20 03:01:00 rolling-vm-freebsd1 >> postfix/showq[66274]: fatal: initgroups: Socket operation on >> non-socket >> ---------------------------------------------------------------------- >>=20 >> So I rebuilt, reinstalled and restared Postfix=2E Then error message >> disappeared=2E >>=20 >> I checked commit log between b0e7b55a0e90 and b3468202994f, and found >> following one=2E >>=20 >> ---------------------------------------------------------------------- >> commit 0b018cfd81d8 >> Author: Olivier Certner >> AuthorDate: Tue Sep 16 17:52:20 2025 +0200 >> Commit: Olivier Certner >> CommitDate: Wed Sep 17 14:16:06 2025 +0200 >>=20 >> initgroups(3): Fix return value on allocation failure >> =20 >> We must not return ENOMEM, but rather -1 with 'errno' set to >> ENOMEM, as described in the manual page and as other implementations >> are doing=2E A malloc() failure actually already sets ENOMEM for us=2E >> Add comments indicating which function set 'errno' each time we >> return=2E=20 >> While here, improve style and remove useless headers=2E >> =20 >> Reviewed by: kib, emaste >> Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS >> and NGROUPS_MAX, =2E=2E=2E") MFC after: 5 days >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews=2Efreebsd=2Eorg/D52580 >> ---------------------------------------------------------------------- >>=20 >> According to commit message, it is likely that the commit introduces >> some incompatibility with initgroups(3) and that it causes error >> messages of Postfix=2E And if it is correct, then __FreeBSD_version >> should be bumped to force packages that use initgroups(3) to be >> rebuilt=2E >>=20 >> --- >> Yasuhiro Kimura >>=20 > >I can confirm this issue=2E I've had to recompile audio/musicpd >and sysutils/bareos23-client to resolve it=2E (Also getting >the same Socket operation on non-socket in each case)=2E > I can confirm as well with postfix, the krb5 port, nut, openldap26-server,= dovecot, and others that I cannot recall ATM=2E --=20 Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD=2Eorg NTP: Web: https://nwtime=2Eorg e^(i*pi)+1=3D0 Pardon the typos=2E Tiny keyboard in use=2E