From nobody Sat Sep 20 08:54:43 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTNVN0mRXz68VsB for ; Sat, 20 Sep 2025 08:54:52 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTNVN00yDz3wRH; Sat, 20 Sep 2025 08:54:52 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758358492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ueFF1w/sBxvJ1DF66jWOiQW9jHuDfHF+T8rKfriqb+0=; b=gE3io4aoGp+YHV8PATGHXqsSsiTpKzcewLFEPqK1N4Cbx4vJ9JsRgPOPrZnC9c3K6KtDpg JrjP7sLq4X0QdV1nV91jV2E1xTU1Fc6ZXgui9anPK7fyiRzgJCJ34x+XPAuYSw/ls+3gue 1q0Bbk0uDuM15sGYDHq09H/QSwwwz8YhQgYp048FHytmWiisZYgIcq/Wtf7N2/WMe6kWTR FifueHXr3WdUlFDwibEQA4UqQ7dyu3uCcukNBTl/zl4pe+8GUw4ttxXr+sXbmrdqxEEpWK WhKFk6RxHmgp3sPJ5jrqmpaMtu+sAleViLCvYGvfptpZ2DQHyDsAh32T469I5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758358492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ueFF1w/sBxvJ1DF66jWOiQW9jHuDfHF+T8rKfriqb+0=; b=FyU6yI+qzlqee+t1oADdWW+TbD025sW4JvCjJT479tGkxd6/J2KbaIr5a6dtaks5ROHqQ0 MyGHa/7Tfd/lXqJrkC9itg8c7/o095ywknQeIfJ7GgL98tmv4eSu6PoJ4w6JcxTIbUdsD5 sn2UMhznV0pB6lDJ1LzQ9mgztWRu37z5L95kbnX1sR+qyH2en7eVP5xYrDjCxsre/Vp+0A 7iueyz4IdVy/kk+JP7RnEzdkPjRGUbNXB6BKpuKIG/wNwgvNM4tclXUjWvFiOGmzQ1WvkA 6/4Zk3ERYazuFlIpqB5djf/F35Vo0py32p6mrsMrtxhyo0gRMvqjgMD1IHbd6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758358492; a=rsa-sha256; cv=none; b=WVseE+P8opsrIFvxJLg3CJzdkWU1lnW5JCpuI+rxJ281r6BgG0aM1VnvKkcbZTLhoN0xeA EnO7WAivrJy89mVGaWc9SsGaWeE4GVyDQYwGABWjgEnbA2wA1LDtc9djCmKF+oe0rj/5hV VrJAMiXlPlbQcXqCvZjDe0VOGaipUmrntoWXKoIxwv9ftYG5gfrxznG8CXchJODqlD0Yyx FlCbpNqquJguFqdgyjQhZcr/Ei56sqk/5ndRjmAnJFPB1Q9srJNNVSLuBiljHYQO5P1stF gorQ/ObWJ/VVSuGkfPe80eKi2D73c2F6A7wcbJmHC3Dq1j4QQWb2TBWV2xfSfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ravel.localnet (aclermont-ferrand-653-1-222-123.w90-14.abo.wanadoo.fr [90.14.66.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cTNVM497QzRGR; Sat, 20 Sep 2025 08:54:51 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Yasuhiro Kimura Cc: freebsd-current@freebsd.org Subject: Re: Possible incompatible change with initgroups(3)? Date: Sat, 20 Sep 2025 10:54:43 +0200 Message-ID: <3124332.hHqAuc6tWs@ravel> In-Reply-To: <20250920.080248.183796883139076827.yasu@FreeBSD.org> References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2478332.THHZn3L5Ee"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart2478332.THHZn3L5Ee Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner To: Yasuhiro Kimura Cc: freebsd-current@freebsd.org Subject: Re: Possible incompatible change with initgroups(3)? Date: Sat, 20 Sep 2025 10:54:43 +0200 Message-ID: <3124332.hHqAuc6tWs@ravel> In-Reply-To: <20250920.080248.183796883139076827.yasu@FreeBSD.org> References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> MIME-Version: 1.0 Hi Yasuhiro, > I checked commit log between b0e7b55a0e90 and b3468202994f, and found > following one. > > ---------------------------------------------------------------------- > commit 0b018cfd81d8 > Author: Olivier Certner > AuthorDate: Tue Sep 16 17:52:20 2025 +0200 > Commit: Olivier Certner > CommitDate: Wed Sep 17 14:16:06 2025 +0200 > > initgroups(3): Fix return value on allocation failure > > (snip) > ---------------------------------------------------------------------- > > According to commit message, it is likely that the commit introduces > some incompatibility with initgroups(3) and that it causes error > messages of Postfix. This commit has absolutely nothing to do with what you are observing: ---------------------------------------------------------------------- Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: fatal: initgroups: Socket operation on non-socket Sep 20 03:00:11 rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgroups: Socket operation on non-socket Sep 20 03:01:00 rolling-vm-freebsd1 postfix/showq[66274]: fatal: initgroups: Socket operation on non-socket ---------------------------------------------------------------------- There is no sign of out-of-memory anywhere here. It is true that this commit introduces a slight incompatibility, but we sometimes do that for bug fixes and in this case there should be only benefits (programs test for failure either with 'error != 0', which hasn't changed, or 'error == -1', which now will work correctly, preventing the program to continue without the expected credentials, or 'error < 0', same). The culprit is without doubt https://cgit.freebsd.org/src/commit/?id=9dc1ac8691966480, whose purpose is precisely to restore initgroups(3) compatibility that was lost after getgroups(2)/setgroups(2) semantics change. Why the symbol versioning mechanisms we are leveraging there don't work as intended isn't yet clear (to me at least), but this is clearly a bug as our intent is precisely that nobody has to recompile anything for things to continue working as before. FYI, we are pursuing that in https://reviews.freebsd.org/D52641. Thanks and regards. -- Olivier Certner --nextPart2478332.THHZn3L5Ee Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmjOa9MACgkQjKEwQJce Jif0BxAAtMyLZZxXf6IWA8LNuaxFJV9ugNb8rQ5eYYYB2niEDdn+RfN2sxBFMlLv Yz/Of52+KPXh0/KYsnVr4oY0NFm7rAbOJvFKAH1sr+uZrbjKJXt1nmSqi3R9LEIA Ug6G7nSl8AfQmasqBvKVDw66LkpUnXUCPtWGGWSbLOJ3iEVbUYrKZM/W63wQPgS9 zDYlw3kWrnySBDeLK5P/nzZUHe6bolEtkjx2pwAGtCb2uNv6DntPDn6v9glfWC4M UUUi2p5u4uy4B9xmi0esEugPJQsl0tHBicTFQS9ZS2WU59paVMCAMJBOeC+tlxDD JQv4k0Hz/G9gvpe7Rl6lMPQB8pj97RcYTajxrKYonMqAaeOOfcWW4IkmJetVx722 fBWZ1Gw2s9NrUqq3BMdpd5GDYXBc6SjyByMEhHthboiR2kfimu35Y2CEWuo3Wbyd iRdRJAeIvD22NtMC4dBlLWYr19WBflnSm4Xwvq000OEbTAQio+NLss+P6zKDK8S0 fkRg4dYQaDSLSVb8Rtg5pwHZW4Ef/8P4deOi1QkrUa/mUPJlIhRuTC0nospNr0aI 1g62v+5w2ur7bv9GtIbBmLsqNEwKyeipUp0aQC6xrgExqyzglOkZEqKqr6j6Ng0a HQk3J1QeSp9wi+907DANRnSVjGG4WP13Wl7szFLc8aa/SsFEG4c= =0Hzo -----END PGP SIGNATURE----- --nextPart2478332.THHZn3L5Ee--