From nobody Sat Sep 20 01:36:01 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTBm60TkKz68095 for ; Sat, 20 Sep 2025 01:36:06 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTBm55dBGz474H for ; Sat, 20 Sep 2025 01:36:05 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-ea5d1270b56so2960052276.1 for ; Fri, 19 Sep 2025 18:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758332164; x=1758936964; darn=freebsd.org; h=mime-version:subject:user-agent:references:in-reply-to:message-id :date:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zww3onqjQmQfS+LxOpVX+/DdiuuTQh81ivHfrCp9a/k=; b=lOvQQH2L04pXTVijxWFQ77PF+7u6F3mJYVNuXeGYr/I40Tu3bJ/CzjOe78PYH4GnM1 Docx10qCAtR5oe0Uv8h++WBU9wTFhVw2OQjltEvAoGWb6gqKJfiajUi9VCYX1pm5KlVu ijuGopdG4xWmog0C7cuMSso016llgzUkpC2DgK2xqFPOEfdf0+eVQR7MNQ2F7lji9DBX jSibQ/xdbezDC6BNnR+f98PgvmBk0s1sEO00KjQTH6v5HbWXDLY1YFuglS3Eds6rvXz+ mVz1YzKJAciSQKmzUYgdZBXDc41yvW9rztuJq1e1wTYQNeTfbsf8IynMTb7Dl6vSJWkQ 4Zew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758332164; x=1758936964; h=mime-version:subject:user-agent:references:in-reply-to:message-id :date:to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zww3onqjQmQfS+LxOpVX+/DdiuuTQh81ivHfrCp9a/k=; b=MXe9WVH4UoctW23Tl7TNjeuUUbQO2DZfi38ksLAs5xzXz4/nkdVk/k9pF7ptXmruw1 2DBM7sbzKwIaWUl9l2SbMkFm+3AzVX1vKub6H5797My7yuBzcFt2bXnD+rcc/H27I8ui o7yzpZiwFSVQMo5eZw3NwwKp/ONEoN5+C00Wtjt1ckJLA1eCm/IrXr9Mxx9WHUNp3hFy W8mNgWWP98mOeL+YSRT3sw5/O5IX8HoZkvG4UmaeNFgcfAhgHl7haD5s9jtEM5LTL8S8 7hgmkOrbr4cgDmEj4sJj9qZctP/u6thzKACz3c28CkvK2R4c4z2MGraOT98a3ldtOYgv tOjQ== X-Forwarded-Encrypted: i=1; AJvYcCVeDrMQ15jQHVUERg+PlNZsL7InhnEy48GoGl9iduPt0ZEaOJ3QJiN6gUan/FbbZ6uuyVGRKY1NNqI/vXSiWTA=@freebsd.org X-Gm-Message-State: AOJu0YzXHYge8rtlRGGKlhjdtc1ZNXGNyYAPUPYsgW4F3F5TUc9px9de Io2m4ep8PolT7IxqPWl6j7A3DSBnmNQks/USEq5qi08XGOcuMeDJD19x X-Gm-Gg: ASbGncvelGi5WokvkNlouT20C918Zy+h2UcT6FJqqJi7XpFtVhn1ZFFi+nRJhIsVgDy l8/PFR6j8jTud3rb0o8Ga32XWKE+nGZMqf6P1vA5oGp8IUGChtr/moEDqr5kQmOWKXkzI397Fiy w1PQDzQNslDtDPR6ABm7ynX2aBwql7GlEg8/M1GetuOM3Fn1E96z3tFu2z/M0p8eFwew1G2U++0 dSc7YUgVm5oT8gKTlcJ/1d6vZv19FY+XsVsRpSDQ5Oqul8eDp/YoPXe0vioUymygYND1BZkzUYT Ziehf1uCXcW5cM2HtpJR9/uJGF7EjBWpZS1tcxumT+7l7xv5B7EKHBV/i/9cN2ofo4orZ6zyHUz L/wiTlG9OQJszcq5Y4+JxvVlYbENdU+07nrsL2VYdqm1YpQhryajaZEJopDse2T9kd4DIuksY4R nQqAw= X-Google-Smtp-Source: AGHT+IEmgTwcyGBRQHCXE30s8kt21ru0TzA0PDZp1Rj2hkSZNp+gMIXF0jNPPRUUDJ8bxAxCobb+2Q== X-Received: by 2002:a05:6902:2806:b0:e9d:6a31:d514 with SMTP id 3f1490d57ef6-ea8a8a56016mr5154508276.44.1758332163913; Fri, 19 Sep 2025 18:36:03 -0700 (PDT) Received: from [10.0.0.109] (107-128-20-168.lightspeed.tukrga.sbcglobal.net. [107.128.20.168]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-ea5ce974212sm2184842276.26.2025.09.19.18.36.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Sep 2025 18:36:03 -0700 (PDT) From: Ian Freislich To: Kyle Evans , Date: Fri, 19 Sep 2025 21:36:01 -0400 Message-ID: <19964c38be8.28c3.64e08aff09ba5a21b2fc9010d26a90e5@gmail.com> In-Reply-To: References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> <20250920084357.32586ee5@darrin.worldsmith.org> User-Agent: AquaMail/1.55.2 (build: 105502562) Subject: Re: Possible incompatible change with initgroups(3)? List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="19964c38e10332028c37d0d92e" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cTBm55dBGz474H This is a multi-part message in MIME format. --19964c38e10332028c37d0d92e Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On September 19, 2025 19:35:45 Kyle Evans wrote: > On 9/19/25 18:13, Darrin Smith wrote: >> On Sat, 20 Sep 2025 08:02:48 +0900 (JST) >> Yasuhiro Kimura wrote: >> >>> Today I updated my 16.0-CURRENT amd64 system from >>> main-n280279-b0e7b55a0e90 to main-n280498-b3468202994f and noticed >>> Postfix emits such error messages as below. >>> >>> ---------------------------------------------------------------------- >>> Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: fatal: >>> initgroups: Socket operation on non-socket Sep 20 03:00:11 >>> rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgroups: Socket >>> operation on non-socket Sep 20 03:01:00 rolling-vm-freebsd1 >>> postfix/showq[66274]: fatal: initgroups: Socket operation on >>> non-socket >>> ---------------------------------------------------------------------- >>> >>> So I rebuilt, reinstalled and restared Postfix. Then error message >>> disappeared. >>> >>> I checked commit log between b0e7b55a0e90 and b3468202994f, and found >>> following one. >>> >>> ---------------------------------------------------------------------- >>> commit 0b018cfd81d8 >>> Author: Olivier Certner >>> AuthorDate: Tue Sep 16 17:52:20 2025 +0200 >>> Commit: Olivier Certner >>> CommitDate: Wed Sep 17 14:16:06 2025 +0200 >>> >>> initgroups(3): Fix return value on allocation failure >>> >>> We must not return ENOMEM, but rather -1 with 'errno' set to >>> ENOMEM, as described in the manual page and as other implementations >>> are doing. A malloc() failure actually already sets ENOMEM for us. >>> Add comments indicating which function set 'errno' each time we >>> return. >>> While here, improve style and remove useless headers. >>> >>> Reviewed by: kib, emaste >>> Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS >>> and NGROUPS_MAX, ...") MFC after: 5 days >>> Sponsored by: The FreeBSD Foundation >>> Differential Revision: https://reviews.freebsd.org/D52580 >>> ---------------------------------------------------------------------- >>> >>> According to commit message, it is likely that the commit introduces >>> some incompatibility with initgroups(3) and that it causes error >>> messages of Postfix. And if it is correct, then __FreeBSD_version >>> should be bumped to force packages that use initgroups(3) to be >>> rebuilt. >>> >>> --- >>> Yasuhiro Kimura >> >> I can confirm this issue. I've had to recompile audio/musicpd >> and sysutils/bareos23-client to resolve it. (Also getting >> the same Socket operation on non-socket in each case). > > Are you folks using GENERIC, or a custom kernel config? The more interesting > commit here is 9dc1ac8691966480ff8bd9c37dd405b981b41dd5, which would surface a > problem fixed by a rebuild if you're using a custom kernel that does not have > COMPAT_FREEBSD14 enabled. I don't think I'd quite expect that failure mode, > though, so maybe not. I use a custom kernel that has COMPAT_FREEBSD14 and I experienced this last night. Had to recompile bind920, zabbix7_agent, zabbix7_server and freeradius3. Ian --19964c38e10332028c37d0d92e Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
On September 19, 2025 19= :35:45 Kyle Evans <kevans@FreeBSD.org> wrote:

On 9/19/25 18:13, Darrin Smith wrote:
On Sat, 20 Sep 2025 08:02:48 +0900 (JST)
Yasuhiro Kimura <yasu@FreeBSD.org> wrote:

Today I updated my 16.0-CURRENT amd64 system from
main-n280279-b0e7b55a0e90 to main-n280498-b3468202994f an= d noticed
Postfix emits such error messages as below.

---------------------------------------------------------= -------------
Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: f= atal:
initgroups: Socket operation on non-socket Sep 20 03:00:1= 1
rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgrou= ps: Socket
operation on non-socket Sep 20 03:01:00 rolling-vm-freebs= d1
postfix/showq[66274]: fatal: initgroups: Socket operation= on
non-socket
---------------------------------------------------------= -------------

So I rebuilt, reinstalled and restared Postfix. Then erro= r message
disappeared.

I checked commit log between b0e7b55a0e90 and b3468202994= f, and found
following one.

---------------------------------------------------------= -------------
commit 0b018cfd81d8
Author:     Olivier Certner <olce@FreeBSD.or= g>
AuthorDate: Tue Sep 16 17:52:20 2025 +0200
Commit:     Olivier Certner <olce@FreeBSD.or= g>
CommitDate: Wed Sep 17 14:16:06 2025 +0200

initgroups(3): Fix return value on allocation failure

We must not return ENOMEM, but rather -1 with 'errno' set= to
ENOMEM, as described in the manual page and as other impl= ementations
are doing. A malloc() failure actually already sets ENOME= M for us.
Add comments indicating which function set 'errno' each t= ime we
return.
While here, improve style and remove useless headers.

Reviewed by:    kib, emaste
Fixes:          54404cfb13d4 ("I= n preparation for raising NGROUPS
and NGROUPS_MAX, ...") MFC after:      5 d= ays
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/= D52580
---------------------------------------------------------= -------------

According to commit message, it is likely that the commit= introduces
some incompatibility with initgroups(3) and that it cause= s error
messages of Postfix. And if it is correct, then __FreeBSD= _version
should be bumped to force packages that use initgroups(3)= to be
rebuilt.

---
Yasuhiro Kimura


I can confirm this issue. I've had to recompile audio/mus= icpd
and sysutils/bareos23-client to resolve it. (Also getting=
the same Socket operation on non-socket in each case).


Are you folks using GENERIC, or a custom kernel config? &= nbsp;The more interesting
commit here is 9dc1ac8691966480ff8bd9c37dd405b981b41dd5, = which would surface a
problem fixed by a rebuild if you're using a custom kerne= l that does not have
COMPAT_FREEBSD14 enabled.  I don't think I'd quite e= xpect that failure mode,
though, so maybe not.

I use a custom kernel t= hat has COMPAT_FREEBSD14 and I experienced this last night. Had to recompil= e bind920, zabbix7_agent, zabbix7_server and freeradius3.

Ian
--19964c38e10332028c37d0d92e--