From nobody Fri Sep 19 23:35:29 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cT84z1rj8z67p7s for ; Fri, 19 Sep 2025 23:35:31 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cT84z0z7qz3rNP for ; Fri, 19 Sep 2025 23:35:31 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758324931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7NJgStZ9hNVUK6n+4QYBf3J7v4Tr3qlDrebbBXZfQQ=; b=fu/v4xh6YTkO/BvkDNvxe6309fLDpeWRQyjIvMZt2oGnAxNFafj3bqkm5oq94ZwJM/3jSP eqBPMyKI7/XU+peszu8Y/FHpiuF34wEE+G4DJTnlQZLsqqfnra7wQScqJkUiokgZ5Ei+J9 Io79cjLjFVafnACqOR8zQPFC7xLOa+hEt6EhZ/Y3CVGCRgiMCtUyjtIEsmHTrcCORZhlMO XGNIn2rYrci47sc9ouZ/C78tinyyODAqdCUfXnxHDxX9ux0CT2So694M2DjxnDhtqHWmWP dMqE9Adv/sHa/j6YnzDWEzSxAi2w+W6c8G/SKpvSeLvdpz44tNCBPeQyP8P81g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758324931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7NJgStZ9hNVUK6n+4QYBf3J7v4Tr3qlDrebbBXZfQQ=; b=nL+Q1JBTcDef7P4+egUz6PJV9LcjgIW6OQtFbSsrNPCQD8SQGzccNEN1F84dxVRUFJHi9y rQL/Ap9LcIrBEJbcjZPSN6UCxUbnHNer9C3vTv+jXz+CQUOvZ6ylMTdEOSZ+/YZaxK2ukw h/kBrGiIHiuP2akdFPKucwizUE8wBOQynx+VTOmuiuCKsACGWWRVvuWfGGyfGslIXyJepA TT1XdatZo1aXUE69pMtIMXSntYJQuEnSLDNBpon14x7vxnol+GuU7xR40fllmCamwEKsqI gfBubkUQUZb6YIu8Clw1Tm3X3i5nojaWNa+bWl/b8/1ucuqgM7lgppIgZdO4sw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758324931; a=rsa-sha256; cv=none; b=dflxcLUM5r24ja/KFoR0ztsvM6aWeELYFmxtTBaWyR6fQZW8iWukv3q0BAoF574Ap7T5rT b4pJ5fGsYynZ/FMtq6sl8B2Q3H/n+SFO4qnM/9cdL+F8TMyEzdwIKQv3TELBIgeJUp/WbK 8+ZHKFp3UB//FpFv0/nASiLBpc8kMTdHeKKM6iasGtlzg67d+KSXO3D7L+lLsUHEyRu5Tr EBh4q484/nUyzgAhJXT6q6JfNQ52UxVOJFPiYlQQun+31QfJNqhTiaxd/zamI+r5CequW9 pNCY7FL4LBAtnh7ZxEJ6MbQhAV1QYuQXNe/IFxoXV6govo6JlAciLg+RWRgHbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cT84y6TYWzF85 for ; Fri, 19 Sep 2025 23:35:30 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Fri, 19 Sep 2025 18:35:29 -0500 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Possible incompatible change with initgroups(3)? To: freebsd-current@freebsd.org References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> <20250920084357.32586ee5@darrin.worldsmith.org> Content-Language: en-US From: Kyle Evans In-Reply-To: <20250920084357.32586ee5@darrin.worldsmith.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/19/25 18:13, Darrin Smith wrote: > On Sat, 20 Sep 2025 08:02:48 +0900 (JST) > Yasuhiro Kimura wrote: > >> Today I updated my 16.0-CURRENT amd64 system from >> main-n280279-b0e7b55a0e90 to main-n280498-b3468202994f and noticed >> Postfix emits such error messages as below. >> >> ---------------------------------------------------------------------- >> Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: fatal: >> initgroups: Socket operation on non-socket Sep 20 03:00:11 >> rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgroups: Socket >> operation on non-socket Sep 20 03:01:00 rolling-vm-freebsd1 >> postfix/showq[66274]: fatal: initgroups: Socket operation on >> non-socket >> ---------------------------------------------------------------------- >> >> So I rebuilt, reinstalled and restared Postfix. Then error message >> disappeared. >> >> I checked commit log between b0e7b55a0e90 and b3468202994f, and found >> following one. >> >> ---------------------------------------------------------------------- >> commit 0b018cfd81d8 >> Author: Olivier Certner >> AuthorDate: Tue Sep 16 17:52:20 2025 +0200 >> Commit: Olivier Certner >> CommitDate: Wed Sep 17 14:16:06 2025 +0200 >> >> initgroups(3): Fix return value on allocation failure >> >> We must not return ENOMEM, but rather -1 with 'errno' set to >> ENOMEM, as described in the manual page and as other implementations >> are doing. A malloc() failure actually already sets ENOMEM for us. >> Add comments indicating which function set 'errno' each time we >> return. >> While here, improve style and remove useless headers. >> >> Reviewed by: kib, emaste >> Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS >> and NGROUPS_MAX, ...") MFC after: 5 days >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D52580 >> ---------------------------------------------------------------------- >> >> According to commit message, it is likely that the commit introduces >> some incompatibility with initgroups(3) and that it causes error >> messages of Postfix. And if it is correct, then __FreeBSD_version >> should be bumped to force packages that use initgroups(3) to be >> rebuilt. >> >> --- >> Yasuhiro Kimura >> > > I can confirm this issue. I've had to recompile audio/musicpd > and sysutils/bareos23-client to resolve it. (Also getting > the same Socket operation on non-socket in each case). > Are you folks using GENERIC, or a custom kernel config? The more interesting commit here is 9dc1ac8691966480ff8bd9c37dd405b981b41dd5, which would surface a problem fixed by a rebuild if you're using a custom kernel that does not have COMPAT_FREEBSD14 enabled. I don't think I'd quite expect that failure mode, though, so maybe not.