From nobody Fri Sep 19 23:13:57 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cT7cN6CCKz67mvQ for ; Fri, 19 Sep 2025 23:14:12 +0000 (UTC) (envelope-from beldin@worldsmith.org) Received: from mail.worldsmith.org (mail.worldsmith.org [IPv6:2404:9400:2:0:2:5751:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 4cT7cL4Z1Sz3p42 for ; Fri, 19 Sep 2025 23:14:10 +0000 (UTC) (envelope-from beldin@worldsmith.org) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=reject) header.from=worldsmith.org; spf=pass (mx1.freebsd.org: domain of beldin@worldsmith.org designates 2404:9400:2:0:2:5751:0:1 as permitted sender) smtp.mailfrom=beldin@worldsmith.org Received: from darrin.worldsmith.org (unknown [IPv6:2400:a848:404e:10::3]) by mail.worldsmith.org (Postfix) with ESMTPSA id 896FDFCF for ; Sat, 20 Sep 2025 08:43:58 +0930 (ACST) Date: Sat, 20 Sep 2025 08:43:57 +0930 From: Darrin Smith To: freebsd-current@freebsd.org Subject: Re: Possible incompatible change with initgroups(3)? Message-ID: <20250920084357.32586ee5@darrin.worldsmith.org> In-Reply-To: <20250920.080248.183796883139076827.yasu@FreeBSD.org> References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.50; amd64-portbld-freebsd16.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.15 / 15.00]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.96)[-0.956]; DMARC_POLICY_ALLOW(-0.50)[worldsmith.org,reject]; NEURAL_HAM_MEDIUM(-0.50)[-0.498]; R_SPF_ALLOW(-0.20)[+mx]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:133159, ipnet:2404:9400:2::/48, country:AU]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1] X-Rspamd-Queue-Id: 4cT7cL4Z1Sz3p42 On Sat, 20 Sep 2025 08:02:48 +0900 (JST) Yasuhiro Kimura wrote: > Today I updated my 16.0-CURRENT amd64 system from > main-n280279-b0e7b55a0e90 to main-n280498-b3468202994f and noticed > Postfix emits such error messages as below. > > ---------------------------------------------------------------------- > Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: fatal: > initgroups: Socket operation on non-socket Sep 20 03:00:11 > rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgroups: Socket > operation on non-socket Sep 20 03:01:00 rolling-vm-freebsd1 > postfix/showq[66274]: fatal: initgroups: Socket operation on > non-socket > ---------------------------------------------------------------------- > > So I rebuilt, reinstalled and restared Postfix. Then error message > disappeared. > > I checked commit log between b0e7b55a0e90 and b3468202994f, and found > following one. > > ---------------------------------------------------------------------- > commit 0b018cfd81d8 > Author: Olivier Certner > AuthorDate: Tue Sep 16 17:52:20 2025 +0200 > Commit: Olivier Certner > CommitDate: Wed Sep 17 14:16:06 2025 +0200 > > initgroups(3): Fix return value on allocation failure > > We must not return ENOMEM, but rather -1 with 'errno' set to > ENOMEM, as described in the manual page and as other implementations > are doing. A malloc() failure actually already sets ENOMEM for us. > Add comments indicating which function set 'errno' each time we > return. > While here, improve style and remove useless headers. > > Reviewed by: kib, emaste > Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS > and NGROUPS_MAX, ...") MFC after: 5 days > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D52580 > ---------------------------------------------------------------------- > > According to commit message, it is likely that the commit introduces > some incompatibility with initgroups(3) and that it causes error > messages of Postfix. And if it is correct, then __FreeBSD_version > should be bumped to force packages that use initgroups(3) to be > rebuilt. > > --- > Yasuhiro Kimura > I can confirm this issue. I've had to recompile audio/musicpd and sysutils/bareos23-client to resolve it. (Also getting the same Socket operation on non-socket in each case). -- =b