From nobody Thu Sep 11 15:48:21 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cN25w19CXz66q4l for ; Thu, 11 Sep 2025 15:48:36 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cN25v4wdjz47yP for ; Thu, 11 Sep 2025 15:48:35 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-622b4b14a75so1749333a12.1 for ; Thu, 11 Sep 2025 08:48:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757605714; x=1758210514; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2xxMbKMT1uFozCiRu89nbfKHApFt9Xx7bIkBKJghVjA=; b=LGyQ5kM9XmGmuk7GQcVddOPPydEvOLF0mFj2FgpkGpOkwPThMphE+sXEPn9ksDaRQP XpOEfCwF99wT9tFMoEtmN22lTv3FfDdqs1lVH+SXak+p8aGR43YhvVNRfXhABkUFRy5B LrjdfjUn7tdl3+g1LIksKhTkvPq7a5YYDa11uuAOtLWHpS816O2HApHgmXuQgpkusGp1 5mJidtq7oC2dmiNeSprgd9o9XTpe7Ryu0fDzwlx0LuYJcBf3jp90od2RVkdSD3mVxtrM a4p4x5PQHnCOWnLt3mc3mzDkJqCjvsABmcAfuFj7G/gw72SYcgUIJl760K5FyI+vf6QV Glug== X-Gm-Message-State: AOJu0Yyd5TW49NcMUha5+zsb2VlFmd5keOkb3deW+8h6DbspnpUkE86D oS410jR4m43QxiFw3LvAag4jtLEh4rUAs5TWfcSbVtcqnNIkm4oaXuGtI9MzJ/pScQTCuYpLNsK EbizjHzLtNMMdX3faBBRUadUPj97EBKA= X-Gm-Gg: ASbGncuJy/iSIqupPw3IfIjZ74vAcohyv0IajZgDfmMRPF2L4hVcFeTJ7ZIdjaCItKy gcTGa+zNUBSe7fe/iIYIu+HBZbNJnjAMxgTziq5EAWLhzZ42TG/WVMlRmvyGaL8fWOr2KF2moht U7wIfZdBDyOq8l4MjFv9VTUXiqCOUur+Epi3MoHIEpgeArQ/KhPZtkzyQtsKyR0G0rEA1sqnJ4P gWoRIGgBwH+EVLfKhPaS48WgqyT X-Google-Smtp-Source: AGHT+IFyfy57NYZqc/R4MsrxoYfq+iNm4R6yfvrn1XRoM6WlhMj7MXmGFWTiK6UsS9nAsKISU80cjhVdgVoOx/Kg+CU= X-Received: by 2002:a05:6402:4548:b0:62d:6cac:1ec2 with SMTP id 4fb4d7f45d1cf-62ed81ff98bmr59007a12.4.1757605714130; Thu, 11 Sep 2025 08:48:34 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <1F6A4621-1505-4F78-97C6-85EA556B2165.ref@yahoo.com> <1F6A4621-1505-4F78-97C6-85EA556B2165@yahoo.com> <86bjnhi7s2.fsf@ltc.des.dev> <86zfb1ghj7.fsf@ltc.des.dev> In-Reply-To: From: Alan Somers Date: Thu, 11 Sep 2025 09:48:21 -0600 X-Gm-Features: AS18NWCHB6hCgo3cjmukBuGVv_n5gn2jcP15Z-koST1PchhMIa2uo4g1fSKOkfM Message-ID: Subject: Re: git: d549de769055 - main - libc: Remove readdir_r(3) [This broke building rust 1.88] To: Toomas Soome Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="0000000000003f1bbf063e8878bc" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cN25v4wdjz47yP --0000000000003f1bbf063e8878bc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2025 at 9:45=E2=80=AFAM Toomas Soome wrote: > > > On 11. Sep 2025, at 18:10, Mark Johnston wrote: > > On Thu, Sep 11, 2025 at 05:01:16PM +0200, Dag-Erling Sm=C3=B8rgrav wrote: > > Alan Somers writes: > > Dag-Erling Sm=C3=B8rgrav writes: > > Tell that to the Rust developers. They have been repeatedly warned > against using readdir_r(3) for years, as far back as 2016. > > Have they? Looking at rust's github page, I see discussions about > using readdir_r on Fuchsia and Linux, but nothing about BSD. > > > If you look at these tickets, there are people pointing out that > readdir_r() doesn't work correctly even on platforms where it isn't > formally deprecated. The Rust developers chose to fix the Linux case > because it produced a link-time warning and ignored the rest. That's on > them. > > They also seem to be providing their own prototype for readdir_r(), > which suppresses the deprecation warning they should be getting on > FreeBSD 15, and turns the issue from a failure to compile into a failure > to link. That's also on them. > > > It doesn't really matter whose responsibility it is. If rust can't be > compiled on FreeBSD after a FreeBSD change, then it's up to us to fix > it. The purpose of FreeBSD, like any other useful OS, is to run the > software that people want to run. > > +1 to Alan's request to back out the change for now. > > > > How about putting up pull request for rust to fix it?;) > That should certainly be done. I'll try to do it this weekend, if I have time. However, the need to revert this change will remain. FreeBSD 15 needs the ability to run both current and old Rust toolchains. --0000000000003f1bbf063e8878bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Sep 11, 2025 at 9:45=E2=80=AFAM Tooma= s Soome <tsoome@me.com> wrote:


On 11. Sep 2025, at 18:10, Mark Johnston <markj@FreeBSD.o= rg> wrote:

On Thu, Sep 11, 2025 at 05:01:16PM +0200, Dag-Erling Sm=C3=B8rgrav wrote:<= /span>
Alan So= mers <asomers@f= reebsd.org> writes:
Dag-Erling Sm=C3=B8= rgrav <des@freebsd.= org> writes:
Tell that to the Rust deve= lopers.=C2=A0 They have been repeatedly warned
against using readdir_r(3= ) for years, as far back as 2016.
Have they?=C2=A0 Looking = at rust's github page, I see discussions about
using readdir_r on Fu= chsia and Linux, but nothing about BSD.

If you look at = these tickets, there are people pointing out that
readdir_r() doesn'= t work correctly even on platforms where it isn't
formally deprecate= d.=C2=A0 The Rust developers chose to fix the Linux case
because it prod= uced a link-time warning and ignored the rest.=C2=A0 That's on
them.=

They also seem to be providing their own prototype for readdir_r(),=
which suppresses the deprecation warning they should be getting on
F= reeBSD 15, and turns the issue from a failure to compile into a failure
= to link.=C2=A0 That's also on them.

It doesn't really matt= er whose responsibility it is.=C2=A0 If rust can't be
compiled on Free= BSD after a FreeBSD change, then it's up to us to fix
it.=C2=A0 The pu= rpose of FreeBSD, like any other useful OS, is to run the
software that pe= ople want to run.

+1 to Alan's request to back out t= he change for now.

<= div>
How about putting up pull request for rust to fix it?;)<= /div>

That should certainly be done.= =C2=A0 I'll try to do it this weekend, if I have time.=C2=A0 However, t= he need to revert this change will remain.=C2=A0 FreeBSD 15 needs the abili= ty to run both current and old Rust toolchains.
--0000000000003f1bbf063e8878bc--