From nobody Thu Sep 11 15:44:36 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cN21c24SQz66pmw for ; Thu, 11 Sep 2025 15:44:52 +0000 (UTC) (envelope-from tsoome@me.com) Received: from outbound.mr.icloud.com (p-west2-cluster1-host3-snip4-10.eps.apple.com [57.103.68.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cN21b4l2Dz45jp for ; Thu, 11 Sep 2025 15:44:51 +0000 (UTC) (envelope-from tsoome@me.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=me.com header.s=1a1hai header.b="Qq/NIhbA"; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (mx1.freebsd.org: domain of tsoome@me.com designates 57.103.68.73 as permitted sender) smtp.mailfrom=tsoome@me.com Received: from outbound.mr.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-2a-20-percent-2 (Postfix) with ESMTPS id 9F95B1800473 for ; Thu, 11 Sep 2025 15:44:49 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; bh=ttzkHYKGZTH/0UptoJo14JKFzvgqD475j+2Ux8oVUio=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id:x-icloud-hme; b=Qq/NIhbAmK6NSUtUkimEg6lJmTGyHHJS7l8Ql3+6ydnOlZ5/Fk7sKv9cvm5kWMdsWdn4DYEczSOlg8F+WsF/XugHUlCAf6X5yPJcaHKiuxAKIxeH2AuxB/4Uvs/sGLJuFdX0ksg2EygWMhlclaTGr5WrMHoSiXHRaEFIKpKgyO27Z+LkEwcq1iTFBZeSqP2he6EvTp2Scp9uFNvwWJfJ7ltlXpB8IX+XIFtGvmBMh3feMbgUORUA737gavEvNLFvrzCpX8UGZ6KqoCUgE0VmrqGEgVCk9zms4L7H8na+gT+ghzzw7mQijcfFwbROcAlY2vy3UONsDYZcsoLn2VpcYw== Received: from smtpclient.apple (mr-asmtp-me-k8s.p00.prod.me.com [17.57.152.38]) by p00-icloudmta-asmtp-us-west-2a-20-percent-2 (Postfix) with ESMTPSA id E4DC918001D4 for ; Thu, 11 Sep 2025 15:44:48 +0000 (UTC) From: Toomas Soome Content-Type: multipart/alternative; boundary="Apple-Mail=_5E4A66DE-4A44-43C1-9E76-6FE9EAAF60AE" List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: d549de769055 - main - libc: Remove readdir_r(3) [This broke building rust 1.88] Date: Thu, 11 Sep 2025 18:44:36 +0300 References: <1F6A4621-1505-4F78-97C6-85EA556B2165.ref@yahoo.com> <1F6A4621-1505-4F78-97C6-85EA556B2165@yahoo.com> <86bjnhi7s2.fsf@ltc.des.dev> <86zfb1ghj7.fsf@ltc.des.dev> To: FreeBSD Current In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3826.700.81) X-Proofpoint-ORIG-GUID: QhpfO4w_RzMxvtdSNv026C1pUM_MzXwa X-Proofpoint-GUID: QhpfO4w_RzMxvtdSNv026C1pUM_MzXwa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTExMDE0MCBTYWx0ZWRfX4yjM5MrB2sYE IGbP2YpcglHCSP8lQrVXVR2fhFuYPqMdZOgarHnKvTKm5p2FhUqq4V9+ltvJB1UILSMGsMi4g/x Ty46kTE1h8M2voJ3HtipLAOZhlyF1gjy7qGvaAGnpdeO/MIl5ac8dlkPw7imS5j4x/8mc5JApHN 8znwX9Xly/h1Ii1eQ4k8+ycLSGvKDM6bcaFr/X8TG1KyZdWBIRngwZ+ut4MZFrVW+eVrSJ9+eaf /T95OCOvrI65BqfjMC+jT6xmudKraLJT+1yXiejKGLXklOX675pxvCHNoMoE448fRRPa25mDg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-11_02,2025-09-11_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 mlxlogscore=526 adultscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.22.0-2506270000 definitions=main-2509110140 X-JNJ: AAAAAAABz+b35PttwRn54k4o24Nr0+k7mQjdW9Wx0G0j/BIWMb/mKiI0sM9sMc1iNu0JJlX4tkg8pGJoif4uqivKelsBtAwv3bb2QixOVuvcJGVpmNY36+0GT6HD1uRq4Ix9Vepu13H7Q7ecSvr2zD1wpUzVgWzhMl+u3Py4S5qeN0sRfXG2Mdg1jvYB318esaW6JeYNGwD8I4uY2tr6YnS0zebsnTq/UbXSz61fonE7O0ZQT6xPB9n5+hVHw0kFz8f89f5QuJ1RLLCrkChUzchZ1CcFQFsNyip+YMQQGggi5EjTol/FTPPUMg2k0eZQpI0dKrgIz1XqHAjelBGIGYEY4W6B56Ysh5I6VPD+wVeHrN1I8NaGsUSWRtmAmKLkA1+Rh2eB8QUD2szPqP78/b+p1/kkkopsGmZ+XU3MypPQKg2cY83eF2bp0UzSl7ToRNQVHCOQPwJUyLUVW32nqJ/GfP3dd1jxUX3EFBI5edh1ZW3jtY79fCCHQS0/eVvNG1N0SmFzyoUpHvP5DA3d9lL77b4wk6Ro5SJQy+XG3d3pJq7tu4fk6sxS9MCWhHujoCU4+qDVIxKCpDgXmXtmQHfumsLI8oMoTK7bKtog/RQ= X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.30 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[me.com,quarantine]; R_DKIM_ALLOW(-0.20)[me.com:s=1a1hai]; R_SPF_ALLOW(-0.20)[+ip4:57.103.64.0/18]; RWL_MAILSPIKE_VERYGOOD(-0.20)[57.103.68.73:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[57.103.68.73:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_FROM(0.00)[me.com]; TO_DN_ALL(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCPT_COUNT_ONE(0.00)[1]; DKIM_TRACE(0.00)[me.com:+]; FREEFALL_USER(0.00)[tsoome]; ASN(0.00)[asn:714, ipnet:57.103.68.0/22, country:US]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[me.com]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[me.com:dkim] X-Rspamd-Queue-Id: 4cN21b4l2Dz45jp --Apple-Mail=_5E4A66DE-4A44-43C1-9E76-6FE9EAAF60AE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 11. Sep 2025, at 18:10, Mark Johnston wrote: >=20 > On Thu, Sep 11, 2025 at 05:01:16PM +0200, Dag-Erling Sm=C3=B8rgrav = wrote: >> Alan Somers writes: >>> Dag-Erling Sm=C3=B8rgrav writes: >>>> Tell that to the Rust developers. They have been repeatedly warned >>>> against using readdir_r(3) for years, as far back as 2016. >>> Have they? Looking at rust's github page, I see discussions about >>> using readdir_r on Fuchsia and Linux, but nothing about BSD. >>=20 >> If you look at these tickets, there are people pointing out that >> readdir_r() doesn't work correctly even on platforms where it isn't >> formally deprecated. The Rust developers chose to fix the Linux case >> because it produced a link-time warning and ignored the rest. That's = on >> them. >>=20 >> They also seem to be providing their own prototype for readdir_r(), >> which suppresses the deprecation warning they should be getting on >> FreeBSD 15, and turns the issue from a failure to compile into a = failure >> to link. That's also on them. >=20 > It doesn't really matter whose responsibility it is. If rust can't be > compiled on FreeBSD after a FreeBSD change, then it's up to us to fix > it. The purpose of FreeBSD, like any other useful OS, is to run the > software that people want to run. >=20 > +1 to Alan's request to back out the change for now. How about putting up pull request for rust to fix it?;) rgds, toomas= --Apple-Mail=_5E4A66DE-4A44-43C1-9E76-6FE9EAAF60AE Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 11. Sep 2025, at 18:10, Mark Johnston = <markj@FreeBSD.org> wrote:

On Thu, Sep 11, 2025 at = 05:01:16PM +0200, Dag-Erling Sm=C3=B8rgrav wrote:
Alan Somers <asomers@freebsd.org> = writes:
Dag-Erling Sm=C3=B8rgrav = <des@freebsd.org> writes:
Tell that = to the Rust developers.  They have been repeatedly = warned
against using readdir_r(3) for years, as far back as = 2016.
Have they?  Looking at rust's github page, I = see discussions about
using readdir_r on Fuchsia and Linux, but = nothing about BSD.

If you look at these tickets, = there are people pointing out that
readdir_r() doesn't work correctly = even on platforms where it isn't
formally deprecated.  The Rust = developers chose to fix the Linux case
because it produced a = link-time warning and ignored the rest.  That's = on
them.

They also seem to be providing their own prototype = for readdir_r(),
which suppresses the deprecation warning they should = be getting on
FreeBSD 15, and turns the issue from a failure to = compile into a failure
to link.  That's also on = them.

It = doesn't really matter whose responsibility it is.  If rust can't = be
compiled on FreeBSD = after a FreeBSD change, then it's up to us to fix
it.  The purpose of = FreeBSD, like any other useful OS, is to run the
software that people = want to run.

+1 to Alan's request to = back out the change for now.


How about = putting up pull request for rust to fix = it?;)

rgds,
toomas
= --Apple-Mail=_5E4A66DE-4A44-43C1-9E76-6FE9EAAF60AE--