From nobody Thu Sep 11 13:44:11 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cMzLf3c18z66gr7 for ; Thu, 11 Sep 2025 13:44:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cMzLf1DmMz3j5H; Thu, 11 Sep 2025 13:44:26 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b04271cfc3eso94367766b.3; Thu, 11 Sep 2025 06:44:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757598264; x=1758203064; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DCeFn3MsZlAlyGraoTntBAwZ7N0KIUm9RUnxaZqgnUQ=; b=lDDmb4brLFBb3+mR8SZHX2/DOz3w3B2XGUa0Gk5LN2q76GXwgUHa3BxpgvrKPAUfDK S+7I+TZDU/kBjks9f8pd5D9XKYZbBVPK2Nvss+75ShTrp8GJAEVG8DeIRjAhzIKxDE2e t9OVdKgQVBidmhrkWGL8lP/JqWoN7Cc6KqwhJKkyE+yf5GZmxDAO79usu/dsDkdoXkwk NngoAfzMYhfzj9eVjGNENc0yA10vrkuXZtfp7ijbBhllb2vcBnOu3oaeV26EC6IXrzzE yakvyzmhJpQOtQcte7jc/QIIqVn+k9SReDQYTz19VNXfT5qLF6r/TiOQkAdU8zYAP6i3 cQFQ== X-Forwarded-Encrypted: i=1; AJvYcCUFgQMxcuqC8bOLdlEwtnnHLPWVieuQqkSW6tAaYYIiLnT5opOEK1d983vh13xLFF2OIsMQ@freebsd.org, AJvYcCW5dvHKL+WGgJ+uOFfxhP24kzOGes/TLMUpV58VOV4Rej1rpD5ZA4rV3Mnb/HFT08SUXL0BC1+rL9HYAGY19cU=@freebsd.org X-Gm-Message-State: AOJu0YwQ7pa5+ByQ6EMZKyj4Iq0UpsHYrrvuWrKUc5c0o9ogFylqrJcU 3iBiXpMW3AhVFHCk74ji0VAePcrA5RqB6kuL/6+XLHWQvEUwFGjLQ7hGefGSB/zbfwNVNKYxW46 nFfGM4mXsjBgPBhrnFPB5kxs5aSTFrJtvRQ== X-Gm-Gg: ASbGncvj0nvb2hsBu5wzoi7WDSc64ZzGTgMa4REMMFC6mg6glTi0t7Wbh247U4q9XEn yafmOK6r5wW3vGNyD7GbqgU7k9+HwFI6Xtjs8Pyxbi4Zglxix/elPNgQRB9X8GxoJ9z1ZrRBLrt QSUtJXSGnw9z9/EP2dEYtA90AWkxYJXxI1AXIImMeK0k2o9nIwJkznRu068lzbY7p288TptFhD8 bxWowM= X-Google-Smtp-Source: AGHT+IGjoZv7QiHlvGArGV3k/w/6u+XKzIHhH4QUejE/vtovPaUanbzhjwymhuC9vPxNxL9Qhe2LZP3k9o51NfxDP3M= X-Received: by 2002:a17:906:7945:b0:b04:8358:26fa with SMTP id a640c23a62f3a-b04b1687d12mr1890757266b.33.1757598263831; Thu, 11 Sep 2025 06:44:23 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <1F6A4621-1505-4F78-97C6-85EA556B2165.ref@yahoo.com> <1F6A4621-1505-4F78-97C6-85EA556B2165@yahoo.com> <86bjnhi7s2.fsf@ltc.des.dev> In-Reply-To: <86bjnhi7s2.fsf@ltc.des.dev> From: Alan Somers Date: Thu, 11 Sep 2025 07:44:11 -0600 X-Gm-Features: AS18NWAhUY6GMwMZLNc7ZsMHJrQXzV7xFb3WR2MRaepLeILMfwGfelZuVpdjIo4 Message-ID: Subject: Re: git: d549de769055 - main - libc: Remove readdir_r(3) [This broke building rust 1.88] To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: Mark Millard , FreeBSD Current , Konstantin Belousov Content-Type: multipart/alternative; boundary="0000000000002c7065063e86bc1e" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cMzLf1DmMz3j5H --0000000000002c7065063e86bc1e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2025 at 4:49=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav wrote: > Mark Millard writes: > > Example error message text from the log file for the > > rust build via poudriere-devel: > > > > > > =3D note: ld: error: undefined symbol: readdir_r > > >>> referenced by std.d8968a002452916e-cgu.07 > > >>> > std-de94806a57729acc.std.d8968a002452916e-cgu.07.rcgu.o:(std::sys::fs::u= nix::remove_dir_impl::remove_dir_all_recursive::hbe1160129d2c5f7c) > > >>> in archive /wrkdirs/usr/ports/lan > > > g/rust/work/bootstrap/lib/rustlib/x86_64-unknown-freebsd/lib/libstd-de948= 06a57729acc.rlib > > >>> did you mean: readdir_r@FBSD_1.5 > > >>> defined in: /lib/libc.so.7 > > cc: error: linker command failed with exit code 1 (use -v to > see invocation) > > Tell that to the Rust developers. They have been repeatedly warned > against using readdir_r(3) for years, as far back as 2016. > Have they? Looking at rust's github page, I see discussions about using readdir_r on Fuchsia and Linux, but nothing about BSD. But even if they have been "warned", that's not really relevant. We shouldn't cavalierly break the build for such important software. I'm guessing that you didn't do an exp-run for this change, so there is probably other software in ports that is broken, too. I request that this change be reverted. And I request that it remain reverted until such a time as an exp-run passes, possibly with the aid of installing misc/compat14x as a dependency for some ports. --0000000000002c7065063e86bc1e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Sep 11, 2025 at 4:49=E2=80=AFAM Dag-E= rling Sm=C3=B8rgrav <des@freebsd.org<= /a>> wrote:
M= ark Millard <mark= lmi@yahoo.com> writes:
> Example error message text from the log file for the
> rust build via poudriere-devel:
>
>
>=C2=A0 =C2=A0=3D note: ld: error: undefined symbol: readdir_r
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0>>> referenced by std= .d8968a002452916e-cgu.07
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0>>>=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0std-de94806a57729acc.std.d8968a002452= 916e-cgu.07.rcgu.o:(std::sys::fs::unix::remove_dir_impl::remove_dir_all_rec= ursive::hbe1160129d2c5f7c)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0>>> in archive /wrkdi= rs/usr/ports/lan
> g/rust/work/bootstrap/lib/rustlib/x86_64-unknown-freebsd/lib/libstd-de= 94806a57729acc.rlib
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0>>> did you mean: rea= ddir_r@FBSD_1.5
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0>>> defined in: /lib/= libc.so.7
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cc: error: linker command fail= ed with exit code 1 (use -v to see invocation)

Tell that to the Rust developers.=C2=A0 They have been repeatedly warned against using readdir_r(3) for years, as far back as 2016.
=

Have they? Looking at rust's github page, I see dis= cussions about using readdir_r on Fuchsia and Linux, but nothing about BSD.= =C2=A0 But even if they have been "warned", that's not really= relevant.=C2=A0 We shouldn't cavalierly break the build for such impor= tant software.=C2=A0 I'm guessing that you didn't do an exp-run for= this change, so there is probably other software in ports that is broken, = too.=C2=A0 I request that this change be reverted.=C2=A0 And I request that= it remain reverted until such a time as an exp-run passes, possibly with t= he aid of installing misc/compat14x as a dependency for some ports.
--0000000000002c7065063e86bc1e--