From nobody Sat Oct 04 23:16:30 2025 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfLyN2ktWz6B7Fn for ; Sat, 04 Oct 2025 23:16:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfLyN03xSz3Lqt for ; Sat, 04 Oct 2025 23:16:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-3306eb96da1so3026786a91.1 for ; Sat, 04 Oct 2025 16:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1759619801; x=1760224601; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a6aVM5YQyEEquGcXF+8eZDSMIc+RAgIx9+/3n8JFsyA=; b=qxCu+EOLJDlOHPJ4ehP993y38OXHZFR7bp26A5umLQq0VERRKNT7rswH6d9HtI9IYG tsjekRNmvEtewmCCQX78ieyqduO4qTDKlXcsB58F4i4lM88O3VqWdlSi3fWlIC6CAkgD xy9XbmTZ7RZQwz+oMxsqIIg6pLPuSPL/P+ogyjAJvVJZzeIDjfcLoyn28onHil1yxWNJ sLyEvv5zab9f7RIGNwu/T4gSsmHbv7u4BlyXoM1iMX4pRsM9zv5gs6nbFp9FxK++yI7g 4NGB52bSphiAVCfYeX7dHK6Xe0FO8HqH+6jFOIl+BvBmvLilLicB/TADauXJnBc63BX4 CzGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759619801; x=1760224601; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a6aVM5YQyEEquGcXF+8eZDSMIc+RAgIx9+/3n8JFsyA=; b=tslRbrVtly8iQWu30Y7KJX4hkB06qPznomlZp5QNlhPqL85G7bFKzvF5a4iCG8mPkM JKSp/M3FigUfyKFw1XBoEHldB+Fyqt8HdHsVRAGl5x2shx/gWI4TB7fKCm51uDYRoPFa P2ZXI/ouTjHJ1LLlyQQY2lWGFgIQysIod769YeC/YfWP71730Mx6ueId+iFloUuxb6+9 XWzIYEttdxviOngwz4RyEHTawYIvPOYmIiecqXfXRvvyvshxenYObhjoVmupn3hwl7Sa nqwfGoYAFtYslhFHQAFU3HjV1sTNFFKdPuM+TNNxGCOoNLFlLFEvAWtNkIFrJrrEARSr DcvQ== X-Gm-Message-State: AOJu0Yx/DnXlW5Eo8ALhio+R1EHIKtvKmUxWH7siK/5JBO4bWFq8K1HZ VPkSqltOALVxo9OhBCugc0rdBfELDRtKuYldUjMu0gX4Yu79/U0u5SllQJIaTDK0qMw9sYH5k86 gElM5YJ6mT7PTSbHmlwcqi4GKmhSryUfcfg8kpb/VnIpAOxO0YiOc8ZNYeg== X-Gm-Gg: ASbGnct3d4aCH1zATk70vz3ISvLG+lxzDT9B8bniGa4ZFTP1oLaWUx5lh0wXVyz/mft Ry/XLbQXo/81aveTyvTK0XDcotsZ6zbQ/XlSFQg7UajzGpQox7e1Yfd0bVI+7CN840Ckdu02OSp rUd9/nZsASJCXVyIixyI3fF3WuIVf2HWmHWsWog5pER4r3xLX5a2Ang4Ay1Xl5qSTnyeVZl60Xo on37emf23bqBXcjLeolQJSCUMTdlqg= X-Google-Smtp-Source: AGHT+IFS0OBWkKSM+zaTpT0IcfbT/Uq05oyn/fKJleuAP6MotghgQbgo91OPFBsCTygu1UKkjyXvrCsem5cqbELpLCc= X-Received: by 2002:a17:90b:4d11:b0:336:bfcf:c50b with SMTP id 98e67ed59e1d1-339c27dad9amr9554731a91.20.1759619801038; Sat, 04 Oct 2025 16:16:41 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <91r7p6r9-5qos-31qo-64o0-p4r0q2p1opsr@mnoonqbm.arg> In-Reply-To: <91r7p6r9-5qos-31qo-64o0-p4r0q2p1opsr@mnoonqbm.arg> From: Warner Losh Date: Sat, 4 Oct 2025 17:16:30 -0600 X-Gm-Features: AS18NWCU2utfyZ-W38PgRnUnaGdEMWus-mkdSZy2pNImlahs30sIxMVML19UnrI Message-ID: Subject: Re: svnlite code in Makefile.inc1 still needed? To: "Bjoern A. Zeeb" Cc: current@freebsd.org Content-Type: multipart/alternative; boundary="0000000000002e540d06405d69b5" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cfLyN03xSz3Lqt --0000000000002e540d06405d69b5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Oct 4, 2025 at 2:37=E2=80=AFPM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > Hi, > > I beleive there might be a $ too much in two lines or the arguemnts are > not properly shell quoted or something? > > make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character " > " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git" > make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character " > " in variable name "echo r" > > Makes me wonder if svnliteversion magic is still needed? > No. It's unused. And a bit of a nop these days unless you happen to have svn still installed. I never see this error, though. Which shell are you using? https://reviews.freebsd.org/D52912 removes it. Warner --0000000000002e540d06405d69b5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Oct 4, = 2025 at 2:37=E2=80=AFPM Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote:
Hi,

I beleive there might be a $ too much in two lines or the arguemnts are not= properly shell quoted or something?

make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character &qu= ot; " in variable name "eval /usr/bin/svnliteversion /usr/src/src= .git"
make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character &qu= ot; " in variable name "echo r"

Makes me wonder if svnliteversion magic is still needed?

No. It's unused. And a bit of a nop these days unless= you happen to have svn still installed. I never see this error,=C2=A0thoug= h. Which shell are you using?


Warner=C2=A0
--0000000000002e540d06405d69b5--