From nobody Sat Nov 22 17:37:15 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDK6T3cyZz6HWGs for ; Sat, 22 Nov 2025 17:37:37 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDK6S2T5zz3d1S for ; Sat, 22 Nov 2025 17:37:36 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=aGPAfamx; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.30 as permitted sender) smtp.mailfrom=marklmi@yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1763833048; bh=pYMd7st3O5walWCw48e0JtPHxPO9ZqczvKKoYfnK3Hc=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=aGPAfamxkTNEjwYFIsqYZMVXlz5qDsVJzOivc2Vaz8AHGv/HJT8hQbYfmtOcYlAWdHPPSvWI6+ZenXn1Tph1E5TKmTi2XmKZAD0TtjXM9L90ml1NXSVxx2C1fIuDBsB/f4kiHQO7TnqOnDyOvESjZZFCwc7HHVXc/+fZ7Uha9W3hc/786/CQ86um2uBaWshPp+r+6PiZlwah/B7K0WbmMECLsM/Ji4O/bo9QwRr+CmFWhG/erVWRx+JfNiWZcvZRY2XOr4lxS5iVyyQdrETHw0f2ufxu7XbB4tz9wGYf90O071LKDgUIHhNHaQGMz1t8eRR+0bdY5WOugjHbHvx5Ug== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1763833048; bh=l3Qhgb/ePfJw3q9BIcvuYG3W+WHG5OADNoR5Ms5hdYY=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=HvMvDDzPxpBGC55RzMMW5PGsSZiu5MbLA39xiX/oZFopyBEiiGhtvZndti5wJVatZCILI2opnQsdzDbX497BBchYwfuL8y/IlTq9FQElCrftygYCbe0Gqv9z3UnzQmX7q13YstLOIGkFXAwmDZdNfpkmImLbqqK7DHymGg7QU8QHjUxD9bbNAdktKIbitxWB/v8EFZb5vNDA7GXfGtycwJngUk6jL0Y2y2iz9AM5aaG2KXXve6v4Sq1x0eyzjVKwwBJmJcwPkin9X68Km6pGmClbXPrUPLuvacuguundviHzeGxDd9Mp9umK/iDS02Fs+7Z0Fwti+tdpe5BkgU3mJw== X-YMail-OSG: pMAoZukVM1nQHXZ0aKSP5SyV6VOdglL.u5y2SDOUDpEyVQaTIgrsZTp1HR9kQIu TiVToC_7P33Jt_TJWaYeyiUb3VWj6nBiTLcxoeqywT3eeDNiiXyGSdeeHJgntBAx5hMS4J4EzUuJ lqV9XxzlF4N_YSB1sAC9cp.MyHRkJEZCEvB5iDNzJFKk3nijwExmuwTdQwK3kdqcCE6yN08Fku24 khKO_UtRd7N7eRLOYdTMWSKKjOLwdoPbwlUI4AwPGJOT6xotLSXrj3n4SbNhqhfUQTrqDkZkJ9Eo EmvpUspoSAxCH17kquLcZ.acMFJUMk4DIbNd7v9S9Y.Oh7UIhlBYs_2qNFMSQA0MOC_Bqx6TFW6g IYo_MGAmmULuA4c2wAcZwAVROQbemaf5j97Zv6B1HV8YlDDAvRnMl8Pos7JNkjPtsaCuc5ZGZpfT SQjN66wJqOAYlYOko8BLzN4MrhVgcHOBcgyHeO5w30_QpGk5FmhgaEVby8CIuSh8dKAwKsQ9ncoU 7jiES3IOXy06xwIwA24M7Db6sknYtVBX1l8DlyUWuOr65Tl6WTDlYQmTDoSHfCp3CXKP782hJsfr CUaIOkUOuV02.n.vk2XVKPhZUfZVpEnQMQmzjx6qRkHeRfGTxjHEY3BFjbHfnwOsJrNf84HzWwpZ dkFV0028fMkELl_0C0NCX6Gmrwk.VlfD5lxlbIrMJ0WS7CG437SrgzoiUj4H8kW84isT8TZuVyGE YNVYQggBvoyiZfvWVCRbqfmDpPkgPjHFlLC63UMmLsRmM0HZxuH4F5xl8TrZCqn.44QF7WmRd1hR 92QYCNB6O2OYtPpnylTDiza9i9qkdBf03fkb7TPBKWzMqOLC90uLR_FG59vcGPBks2u0TIpJRkd1 2DaPL8AGtv0RXv9TtCgFoOAw_Q_xepWbJZCRTMAilKgOr64X28iUdQVD.jORUPw7yil61kfO02G4 3.zECUfgcVH7VcJnUzv6mKw6mJdiEhR.LcrdLsxouAPmq7WpxEY_aaXCnT.3eSA2yflYbJty5tBP Q.DOFmaGRTbA.mOl0GS2i45iP3RBKyYfArQwGEX9WJf2tWlG2.tOE1q7p_n7ciPDHDIqmwxb6K0y lEz1BenN8Xfj8U5l35uiLg_0JODnaG2JkZgNCosQKhzDgV98_BZafpHfIUrmgU.wTpyNp1mzCM8k ka0qMddXndn6_KMMTHmED.ODPzaXNCW2NFf2nGE7icxQRfOCGrT1O.PYxKHcyC931nSLuT_RgA3O ONaSyDhRpWM5uezYluhJCKg_VivDINdhu3L7pevO.PZe_TC8qnRHFZLL0cuYCLYMdZv4n31H5q9u aOn7gLoEfyzvTHgjMKl9BNwNmvVC5XYsgtB9_uTeRfP50cV1P0mB_jons75Zt1MU_VRLXL8GQIRC K0VO_1_exdOHLCFyWPEELe5rCMZw3n69LmH80uFXNERuS3ABEW.G8G.H4sjufPDG2THu8eX0abK3 xi5TTqI8So18GdIYCbHLWaQp745pYBdvd71VRO.R8xHruCI3V.6EhldKaEgPGkYyFJErCO25lK8C xdGuqfYlXJ6zdIM_8dDIMT.NupvH_m5Z2cymVcCxQuPMF.lmbEHxIJRgXgBULNq5sz4s4x3ONYXP 0G..lTr3FjnFBU1ieNzRXSooVJVP2dPRgr_H8UjmoHJaDIFIfQoLP_8w40A1PnLRPTQ1wszFaqsO aRZ1EPIuZl4qB0Gpyg3SxoZkqPdzSCcX2nDpVbVFQqYy5ChVf065jdn3aV5Cn7EgYOA9vuhqgmMh u10im59ht5PImsbkq29PO2tVbUKKMjqFvV34UHm9QTaa2HNuuXxj2kAfqhqK55CEVhWIcIk1Tt.K OiUTxDJCBrzBrdSS8rn7f05Oq1NbhVGbFmmq9197RInEoLTzYN3weG4n31npfI3zSU_oLyFemWlJ RtlEWBa6kf0BzepQMzE2bzylnTwwBFt6frQpBG7eSectfeeQEg1l1C80wYOz9zjZsGiFrxaX7Whg 2XlL0e_uLosq04neddiYzJMCrhhSoooXUmMBSvya7k2dgkH4Wu3pTcuorc8rGM0gkkIqS5be6Mrh hXe5D.M8ngIi83PSWhDl.rCykXS48rmbckbvJO7zB2nCnFMCwoUaL.66MzJb555BAmKICxkICDEx Nj6V58M_pI2rGt561wvGdtSH1wK23c5vqiWwf5Wje94bp5TQRafSNBje.ooq1qEUUijYX9OHFErK 08Lb0BzeLrTX9uJV7mmacuVH4urTOG2qtWiCEwb5IOr1MuN4YauKrW65akiIeIXgCD083BLz_eik SNydclRfGsBVUHGeRz1rh5GOO X-Sonic-MF: X-Sonic-ID: 310f6f0e-efa7-4944-ab7e-72afffcf2318 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Sat, 22 Nov 2025 17:37:28 +0000 Received: by hermes--production-gq1-fdb64d996-whpwx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3c9a76b6a49b0ec49a173a1940999360; Sat, 22 Nov 2025 17:37:25 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: mmap( MAP_ANON) is broken on current. (was Still seeing Failed assertion: "p[i] == 0" on armv7 buildworld) Message-Id: <7435C4D0-94AF-41FA-B9A0-2E5091F5A727@yahoo.com> Date: Sat, 22 Nov 2025 09:37:15 -0800 To: Michal Meloun , Konstantin Belousov , FreeBSD Current X-Mailer: Apple Mail (2.3826.700.81) References: <7435C4D0-94AF-41FA-B9A0-2E5091F5A727.ref@yahoo.com> X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.73 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_SPAM_SHORT(0.27)[0.273]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_TO(0.00)[freebsd.org,gmail.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FREEMAIL_FROM(0.00)[yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.30:from]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.30:from] X-Rspamd-Queue-Id: 4dDK6S2T5zz3d1S Michal Meloun wrote on Date: Sat, 22 Nov 2025 16:37:19 UTC : > On 22.11.2025 16:40, Konstantin Belousov wrote: > > On Sat, Nov 22, 2025 at 03:31:24PM +0100, Michal Meloun wrote: > >> This patch KASSERTs almost immediately when the system enters = multi-user > >> mode while processing mmap() syscall: > >> > >> panic: vm_object_coalesce: obj 0xc73ddb28 next_pindex 0x13 = next_size 0x5 > >> obj_size 0x176 > >=20 > > Yes, the assert was mis-placed. Please try this variant. > >=20 > > commit 2b1a1bcd2926bd89b8422c665b0aa411e29c883b > > Author: Konstantin Belousov > > Date: Sat Nov 22 16:02:50 2025 +0200 > >=20 > > vm_object_coalesce(): fix logic to detect coalesce possibility, = simplify > >=20 > > diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c > > index 5b4517d2bf0c..9bb4e54edd96 100644 > > --- a/sys/vm/vm_object.c > > +++ b/sys/vm/vm_object.c > > @@ -2189,13 +2189,19 @@ vm_object_coalesce(vm_object_t prev_object, = vm_ooffset_t prev_offset, > > next_size >>=3D PAGE_SHIFT; > > next_pindex =3D OFF_TO_IDX(prev_offset) + prev_size; > >=20 > > - if (prev_object->ref_count > 1 && > > - prev_object->size !=3D next_pindex && > > + if (prev_object->ref_count > 1 || > > + prev_object->size !=3D next_pindex || > > (prev_object->flags & OBJ_ONEMAPPING) =3D=3D 0) { > > VM_OBJECT_WUNLOCK(prev_object); > > return (FALSE); > > } > >=20 > > + KASSERT(next_pindex + next_size > prev_object->size, > > + ("vm_object_coalesce: " > > + "obj %p next_pindex %#jx next_size %#jx obj_size %#jx", > > + prev_object, (uintmax_t)next_pindex, (uintmax_t)next_size, > > + (uintmax_t)prev_object->size)); > > + > > /* > > * Account for the charge. > > */ > > @@ -2222,26 +2228,13 @@ vm_object_coalesce(vm_object_t prev_object, = vm_ooffset_t prev_offset, > > * Remove any pages that may still be in the object from a previous > > * deallocation. > > */ > > - if (next_pindex < prev_object->size) { > > - vm_object_page_remove(prev_object, next_pindex, next_pindex + > > - next_size, 0); > > -#if 0 > > - if (prev_object->cred !=3D NULL) { > > - KASSERT(prev_object->charge >=3D > > - ptoa(prev_object->size - next_pindex), > > - ("object %p overcharged 1 %jx %jx", prev_object, > > - (uintmax_t)next_pindex, (uintmax_t)next_size)); > > - prev_object->charge -=3D ptoa(prev_object->size - > > - next_pindex); > > - } > > -#endif > > - } > > + vm_object_page_remove(prev_object, next_pindex, next_pindex + > > + next_size, 0); > >=20 > > /* > > * Extend the object if necessary. > > */ > > - if (next_pindex + next_size > prev_object->size) > > - prev_object->size =3D next_pindex + next_size; > > + prev_object->size =3D next_pindex + next_size; > >=20 > > VM_OBJECT_WUNLOCK(prev_object); > > return (TRUE); >=20 > Unfortunately, that didn't help. I will try the vm_map.c patch again=20= > for confirmation. On amd64 I could not complete a boot: the KASSERT failed for equality instead of > : "next_pindex Oxf next_size 0x4 obj_size 0x19" QUOTE (from a prior message to the list): No serial console so a summary from a picture (expect typos): . . . ue0: link state changed to UP panic: vm_object_coalesce: obj Oxfffff800090a27c0 next_pindex Oxf = next_size 0x4 obj_size 0x19 . . . vm_object_coalesce vm_map_insert1 vm_map_find_locked pipespace_new pipe_paircreate kern_pipe sys_pipe2 amd64_syscall fast_syscall_common syscall END QUOTE =3D=3D=3D Mark Millard marklmi at yahoo.com