From nobody Sat Nov 01 17:50:42 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4czQPX464rz6GLF9; Sat, 01 Nov 2025 17:50:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4czQPW5h23z43QM; Sat, 01 Nov 2025 17:50:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 5A1Hogti056054; Sat, 1 Nov 2025 19:50:45 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 5A1Hogti056054 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 5A1HogeN056053; Sat, 1 Nov 2025 19:50:42 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 1 Nov 2025 19:50:42 +0200 From: Konstantin Belousov To: Adrian Chadd Cc: freebsd-arm@freebsd.org, freebsd-current@freebsd.org Subject: Re: Buildkernel fails in /usr/obj/usr/src/arm.armv7/sys/GENERIC/vchiq_shim.o Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4czQPW5h23z43QM On Sat, Nov 01, 2025 at 10:22:37AM -0700, Adrian Chadd wrote: > Here's my suggested solution: > > === > diff --git a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > index 96c3a0db8aa5..7e105a6b3b77 100644 > --- a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > +++ b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > @@ -628,7 +628,9 @@ free_pagelist(BULKINFO_T *bi, int actual) > pagelist = bi->pagelist; > > vchiq_log_trace(vchiq_arm_log_level, > - "free_pagelist - %zx, %d (%u bytes @%p)", (size_t)pagelist, > actual, pagelist->length, bi->buf); > + "free_pagelist - %zx, %d (%lu bytes @%p)", > + (size_t)pagelist, (int)actual, (unsigned long)pagelist->length, > + bi->buf); We normally use %jx format specifier together with (uintmax_t) cast to handle integer types MD different sizes. > > num_pages = > (pagelist->length + pagelist->offset + PAGE_SIZE - 1) / > === > > The code /is/ being compiled on my arm64 and armv7 builds, I verified this > by using #error in this source file. But the format strings aren't > eliciting a type violation when I cross compile.