From nobody Sat Nov 01 17:22:37 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4czPn64Wlpz6GGKB for ; Sat, 01 Nov 2025 17:22:50 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4czPn570Sgz3wCd for ; Sat, 01 Nov 2025 17:22:49 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-88032235d68so19535086d6.3 for ; Sat, 01 Nov 2025 10:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762017769; x=1762622569; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p5wNsLkR5DoSy7NFV71ZnamH0XqKV+rFZ46UHlF3CoI=; b=miTNOYaEE3i0Ofh7JlrNMWXHxolcnM4rC+pSGgp92a1cujubo2dAGA098L67TIKo7P N9CXdGrkeLUcJO6cQ3ToY6maUYF7aE5XtxNUTrWbPjLsAsaeyM0TaBYsod1OU0w3zQ9H Ms7tB4UyQENy7OLwbGNhdUofAmn8tx+HsYm+DMp7JcGE0Fn7fqHnClPnWIGVON9LygT0 S9ZiNvMDQeqxVjqEl8Y/KEVyxEVEdBnewGYuGK9vqVTBpeO9/FrdXdSVwy/mPz0HiHPj ch/9ofHOkIRYKYDsNHtML0g22d87Bb+YtIaAEq24M6CuLs3styS41/Io7z+aY1vzqI/v /V+w== X-Forwarded-Encrypted: i=1; AJvYcCXgyBlp4B3CFq7KU0dKt9nAlqcuSGkpEgmhjpk7xW5zG8uE5YM8oES5Yzllj4yLTSz9YES/2kAye9Wn48Ukwuw=@freebsd.org X-Gm-Message-State: AOJu0Ywn+2VDPBLK7Zi4x5C+G6Hpt36cYRN6Bd2U4EnQgwuKnuoSkVZm UAXrB3TmbzAZdyJTdnBGu7v2jMpgCk3Xg1nTFXSNyqiGyMXoaBUZzwoHB3nExVT1yPuz1ZTSCax 5LfewGNSq+hruQyjYWdDN2rgEsVThUH4+0BIDvHg= X-Gm-Gg: ASbGncu+eqAdLTIKUrWyhv6pjKWH1VuQd483qCxF1RwJEaMgzQmETGIb1F76daImeZ3 C/49zkjcZWF07b6AlL3F+0KLR/jDI3XBnfNkBIztR1wD1vRl6mhScpRTuXg8jR18FvfRTlspGVV 1jRpADTyr7m33imk4I47oEHJIXrqwSjbcFLfUMQvwBG4NS4vIbTCHByWh0TKqwsONq58/hlCjmD xLRjMtYB8OXpteDoCQNTrmfIgZlOz3lWZ2IhaOWvGPY8CcaaigJg+lHL7KVWWKPrvhO8cbUwg== X-Google-Smtp-Source: AGHT+IFyT82bqVoiGIzOvGAxDqhiw53ypKS2p1TcoAvPxU+8egZcVRjJOh4e2PxEW2TnIJ7wNVTnQ/HeK5wTpWJXTnQ= X-Received: by 2002:ad4:5ec8:0:b0:880:47d8:dec7 with SMTP id 6a1803df08f44-88047d8e4camr34134756d6.44.1762017768922; Sat, 01 Nov 2025 10:22:48 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Sat, 1 Nov 2025 10:22:37 -0700 X-Gm-Features: AWmQ_bnrxk9WIg_cJi1bvi3VDoce1GeCnp13pNiumlrzKwpex5yBCcVJD6lb-mU Message-ID: Subject: Re: Buildkernel fails in /usr/obj/usr/src/arm.armv7/sys/GENERIC/vchiq_shim.o To: Mark Millard Cc: bob prohaska , freebsd-arm@freebsd.org, freebsd-current@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003463b306428bbb87" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4czPn570Sgz3wCd --0000000000003463b306428bbb87 Content-Type: text/plain; charset="UTF-8" Here's my suggested solution: === diff --git a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c index 96c3a0db8aa5..7e105a6b3b77 100644 --- a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c +++ b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c @@ -628,7 +628,9 @@ free_pagelist(BULKINFO_T *bi, int actual) pagelist = bi->pagelist; vchiq_log_trace(vchiq_arm_log_level, - "free_pagelist - %zx, %d (%u bytes @%p)", (size_t)pagelist, actual, pagelist->length, bi->buf); + "free_pagelist - %zx, %d (%lu bytes @%p)", + (size_t)pagelist, (int)actual, (unsigned long)pagelist->length, + bi->buf); num_pages = (pagelist->length + pagelist->offset + PAGE_SIZE - 1) / === The code /is/ being compiled on my arm64 and armv7 builds, I verified this by using #error in this source file. But the format strings aren't eliciting a type violation when I cross compile. --0000000000003463b306428bbb87 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here's my suggested solution:

=3D=3D=3D
diff --git a/sys/contrib/vchiq/interface/vchiq_ar= m/vchiq_2835_arm.c b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c=
index 96c3a0db8aa5..7e105a6b3b77 100644
--- a/sys/contrib/vchiq/inte= rface/vchiq_arm/vchiq_2835_arm.c
+++ b/sys/contrib/vchiq/interface/vchiq= _arm/vchiq_2835_arm.c
@@ -628,7 +628,9 @@ free_pagelist(BULKINFO_T *bi, = int actual)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 pagelist =3D bi->pagelist;=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 vchiq_log_trace(vchiq_arm_log_level,=
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "free_pagelist = - %zx, %d (%u bytes @%p)", (size_t)pagelist, actual, pagelist->leng= th, bi->buf);
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "free_pagelis= t - %zx, %d (%lu bytes @%p)",
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = (size_t)pagelist, (int)actual, (unsigned long)pagelist->length,
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bi->buf);
=C2=A0
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 num_pages =3D
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 (pagelist->length + pagelist->offset + PAGE_SIZE - 1) /=3D=3D=3D

The code /is/ being compiled on my arm6= 4 and armv7 builds, I verified this by using #error in this source file. Bu= t the format strings aren't eliciting a type=C2=A0violation when I cros= s compile.
--0000000000003463b306428bbb87--