From nobody Thu Mar 13 10:51:41 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZD47W6prJz5qT44 for ; Thu, 13 Mar 2025 10:51:51 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [IPv6:2001:19f0:7400:8808:12:4:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 4ZD47V0qZ6z3vh0; Thu, 13 Mar 2025 10:51:49 +0000 (UTC) (envelope-from jamie@catflap.org) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=catflap.org; spf=pass (mx1.freebsd.org: domain of jamie@catflap.org designates 2001:19f0:7400:8808:12:4:0:1 as permitted sender) smtp.mailfrom=jamie@catflap.org X-Catflap-Envelope-From: Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [209.250.224.51]) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5) with ESMTP id 52DApfmh079467; Thu, 13 Mar 2025 10:51:41 GMT (envelope-from jamie@donotpassgo.dyslexicfish.net) Received: (from jamie@localhost) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5/Submit) id 52DApfMi079466; Thu, 13 Mar 2025 10:51:41 GMT (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <202503131051.52DApfMi079466@donotpassgo.dyslexicfish.net> Date: Thu, 13 Mar 2025 10:51:41 +0000 Organization: Dyslexic Fish To: kevans@FreeBSD.org, jamie@catflap.org, freebsd-current@FreeBSD.org Subject: Re: grep(1) bug - duplicate output lines References: <202309280240.38S2esgN015958@donotpassgo.dyslexicfish.net> <8d0658e9-8984-a241-ad1d-e5aa1328d7fa@FreeBSD.org> <202309291629.38TGTU56092229@donotpassgo.dyslexicfish.net> <202309291825.38TIPNN2096338@donotpassgo.dyslexicfish.net> <85039cfe-3c59-173d-f2f2-f0ca8e0fa1c8@FreeBSD.org> <883774ff-c630-72bf-ebc3-cc53e4d40d03@FreeBSD.org> <202503120021.52C0LG7D088609@donotpassgo.dyslexicfish.net> <503a0ad0-7a03-4979-9faf-d220f7b3c3a5@FreeBSD.org> <4e719f32-7be0-46dd-8113-d8bee17a846e@FreeBSD.org> In-Reply-To: <4e719f32-7be0-46dd-8113-d8bee17a846e@FreeBSD.org> User-Agent: Heirloom mailx 12.4 7/29/08 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (donotpassgo.dyslexicfish.net [209.250.224.51]); Thu, 13 Mar 2025 10:51:41 +0000 (GMT) X-Spamd-Result: default: False [0.37 / 15.00]; NEURAL_SPAM_MEDIUM(0.95)[0.949]; NEURAL_SPAM_SHORT(0.60)[0.599]; DMARC_POLICY_ALLOW(-0.50)[catflap.org,none]; NEURAL_HAM_LONG(-0.47)[-0.474]; R_SPF_ALLOW(-0.20)[+mx:dyslexicfish.net]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; HAS_ORG_HEADER(0.00)[]; FREEFALL_USER(0.00)[jamie]; TO_DN_NONE(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:20473, ipnet:2001:19f0:7400::/38, country:US]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MLMMJ_DEST(0.00)[freebsd-current@FreeBSD.org] X-Rspamd-Queue-Id: 4ZD47V0qZ6z3vh0 X-Spamd-Bar: / Kyle Evans wrote: > > Which would have revealed: > > > > Standard output: > > Executing command [ zgrep -e  test ] > > > > Standard error: > > Fail: incorrect exit status: 134, expected: 0 > > stdout: > > > > stderr: > > Assertion failed: (pc->matchidx > 0), function procmatch_match, file / > > usr/src/usr.bin/grep/util.c, line 223. > > Abort trap (core dumped) > > -- > > > > I'll take a little bit to understand the patch I wrote back then, add an > > extra test to cover the originally-reported bug, fix the patch, then get > > it into Phabricator ASAP.  Sorry for dropping this- > > > > Thanks, > > > > Kyle Evans > > > > Here we go: https://reviews.freebsd.org/D49324 Wow, that was quick! Cheers! Yes, despite my best efforts :-), it works perfectly for me (14-stable) Anyway, not only should I have run the tests, I totally forgot about the original issue too - your patch was in my local patch tree, which is distributed to all my hosts, so I forgot the patch hadn't been commited - so much so, when I stumbled upon the current assert issue, I was initially puzzled where the difference between my copy of util.c and the one in current came from! Thanks for your help! Jamie