From nobody Sat Jul 26 20:48:38 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bqH0033L8z62SmV for ; Sat, 26 Jul 2025 20:48:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bqGzz66tSz3nMW for ; Sat, 26 Jul 2025 20:48:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-7e62a1cbf82so195201285a.2 for ; Sat, 26 Jul 2025 13:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753562922; x=1754167722; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=hLx9sXKRum2nuGaBTIFXIQqMl7iCnJOTkQv3zh1U13w=; b=HPyKQjs4KBwB6MDNAG3uD0fGO16nvT0yo+UsZWBjePJdJMsyIBeuyQV2dzpQHxlrEw B3KCfOh6N2Rv11W51dHw/Gj97zLhnED4Y9eMocQeNMmr58ebVaFRhiiCmavvIZxEGno/ lsp3NA/PXjS1od7iklG0kiF4c/i0UGF2sCxyKCv0OvwelNhCYeQ3lBletaLCwGV3EDH3 dPtZb2Z+9PcMBXNTfnkNBixLRhIerirjJUdDrBxQP9TqJ+eQv7WbpUMDTMQtjccNZS79 2Qo8F6JuyPFFPN+BnuW7qLUdKKeZe1Mzfr5b1+lNMGbSTkEDnIwuUwMETKwZRdv5Ifkc I+2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753562922; x=1754167722; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hLx9sXKRum2nuGaBTIFXIQqMl7iCnJOTkQv3zh1U13w=; b=oY0CCOoA306wzNZZZkpPyF1r9UG4W4vednV6EPW28Uf3Uy73EFC3XoxpCE7jvjMCji utaNAht5W/v5Zr31XXP5d1VW1UvqlzLDzYjvSZmfiSAgrZzKkobax7nXv0d9gMqT3U01 P3j3mYp2zqbfqaxYK/qhlaHMDfBYnvp2uH8mp9dVtAfQ64y5XSqeJvXB5hHK+j3oJ1Em 3BliUCFafgASnvpH13rrOsd3Cd3DYd7e0jwc7OmiIkeORlqnME8jmaqetpT9Er5K5RMG mrW1bFhGWFPirSxyweAGrphEEVA6WzALMNYv0hc9fTeAdp/OcPzFdNn6C5noIlDI2axT aLNA== X-Gm-Message-State: AOJu0Yzy4M8XlTp5fOYVFHyAQxf/IZUrZxp6rBtdEEYQxyklZoZy7b25 mVXxwdC3pyvyleK+WpvQB7rr7cp+pcqmSDdhewhiM/mzpCTRoEtfVNDU2GzHePvt X-Gm-Gg: ASbGncsPYt+pdH/9yycuK3bJeHNTE1zs86a/Lrx7KoGBuWC4bF9ECH26piuQlLeCyUs VmvSNAcivH5jHF/TMvuXTqs2avEsaNObA+RcWjFWTyL3lf4Mwyxv0gL+hxOZMahIjBjOM3Azdrt LefV/j3Cin/o1YpzQyfi2j2XobHiT+avGc7t4LXn0br6F55F6DMkp2Wwu0hKMmwBwbdZ+mmp06h ZePxHNarMY8bhHK2S2DlSAdO4MNUbwLUJeOSKRTJXP0uDT+MlraWENCM9QjtErR98d1FFyBO7f5 K9WBWWFWli0RyJUfiTRZFXUD0puH5UgLvxzY+DdIFNkSlkBHSrYa4V/lQJqhII6enrczS4c5xB4 1WEf4Hip7d2arQv77aFrzXwcploFe5ozrI7RR X-Google-Smtp-Source: AGHT+IEX7h60VUOlvNwqxUw4wtwDWIUG/kbvQUjboEjWlfGAXpeSn2RClbIkKx8JqPFxQx5STW/rzA== X-Received: by 2002:ad4:4eeb:0:b0:707:2d2c:4785 with SMTP id 6a1803df08f44-7072d2c4923mr45865946d6.47.1753562921922; Sat, 26 Jul 2025 13:48:41 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70729c6fa0bsm13593236d6.84.2025.07.26.13.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Jul 2025 13:48:41 -0700 (PDT) Date: Sat, 26 Jul 2025 16:48:38 -0400 From: Mark Johnston To: Ian FREISLICH Cc: "freebsd-current@freebsd.org" Subject: Re: acpica/acpi_wakeup.c:115:24: error: use of undeclared identifier 'suspended_cpus' Message-ID: References: <6c2b1459-8855-4e6e-84ba-c515c9d64ab7@gmail.com> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c2b1459-8855-4e6e-84ba-c515c9d64ab7@gmail.com> X-Rspamd-Queue-Id: 4bqGzz66tSz3nMW X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Sat, Jul 26, 2025 at 02:56:14PM -0400, Ian FREISLICH wrote: > Hi > > I get this error compiling for UP but not SMP. The SMP option is mandatory on amd64 after commit fa02551dc8a029a74eb374c418dbb5401d53c2db. There is a static assertion in machdep.c that is supposed to report this, but it seems we should handle it a different way, perhaps in the kernel makefiles. > /usr/src/sys/amd64/acpica/acpi_wakeup.c:115:24: error: use of undeclared > identifier 'suspended_cpus' > 115 | if (!CPU_ISSET(cpu, &suspended_cpus)) > | ^ > /usr/src/sys/amd64/acpica/acpi_wakeup.c:199:32: error: call to undeclared > function 'suspend_cpus'; ISO C99 and later do not support implicit function > declarations [-Werror,-Wimplicit-function-declaration] > 199 | if (!CPU_EMPTY(&suspcpus) && suspend_cpus(suspcpus) > == 0) { > | ^ > /usr/src/sys/amd64/acpica/acpi_wakeup.c:272:4: error: call to undeclared > function 'resume_cpus'; ISO C99 and later do not support implicit function > declarations [-Werror,-Wimplicit-function-declaration] > 272 | resume_cpus(suspcpus); > | ^ > 3 errors generated. > *** Error code 1 > > Stop. > > > Ian >