From nobody Mon Feb 24 07:52:14 2025 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z1XyP6b2kz5q1D8 for ; Mon, 24 Feb 2025 07:52:29 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z1XyP5jQFz3wpm; Mon, 24 Feb 2025 07:52:29 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740383549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EBYMQRIP3ZExGTPAl5pi0UVnr/kcwUFllU7d5pZKvgc=; b=bOGBAtoXj8InVf7nzxzuDRAIlKaC8VzG4gMsVmBwCyhHbhv3dCniL0GCCgsPSSWXCai0MX 1vZ+vTrUrLeWt3RA7yWd86JHNx+ryj2jpVYvwnQdSDutjI++wGsXQzUg35vSkiuYwxcpTg FX1NiZJg349h8PpWMSegt/sBCuVOI4ailLlSavvIFw6D9OK6rIAkgTPFA0t031xD1Yo4oU 6vliLPVSyRVaWbBCVTr8/gtVSYUDrnDwVKsnwAmozBpETJQbYtclZZ/6GBnM+BxfjvmEbp v7TLzX0arZzFIcI7O/DfkD5M0TfI+MyPq/yiiz4oSCd6bgEnMYeAdjGGFjIu4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740383549; a=rsa-sha256; cv=none; b=oncT0SJ3r5PzXJyIDd7+CJfFR6llEv5LMQaeT6A3o/RLOKKcW4OSW3/idE/QGPmjE9g4r/ QxzLHgWBEZM/LO81ad1fPANwWJoQyxz4LMYVhdnml4ItdTx9xM6PSX8jnFUDa0c5HDmpCZ MnO0xBrsTItME73vrNG7Ym+qKjFyRG/gQUtVAkgluWcemefeCh/gbLacVz+j93wDfNONWI v+/NC17HKY67S6URH+6U9GpT1o6Dxqjj4t0BGMtertokDmLZbwUpvFNXBdcTnRqZGwhUD+ ybMvXDWb4lTXp3xeLlZDjQkh//LDSVaNa1jrBqdXCeJsFAAP+3EZDN65kXo5Fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740383549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EBYMQRIP3ZExGTPAl5pi0UVnr/kcwUFllU7d5pZKvgc=; b=Gk1IO0VfFMrpWB94DecrCTa8ZGVKpuffArH1gjqR3253JCOra9wBRtB1wPEJ/bBEeYtCyb F0iQFwK3sSAqFsJ4it26+8IGSpLVi2FGBk3XGSsWITirhZ1Rpi0e+rId4yspIbXLtjb3U3 KAGwioWvPDcVx+8aHHe3zg6kNsb4apZtGPVzHQDh70A/geRdh0uoUmjWkE3Ju74PvWkcMN A7e3L9lfxsJpyvhAaoQcfxlfIPhUjpIVqamMVAExa4QErYuiHkSA7vMP7TsUmKzu45C+qQ CVRKzVzJ9cJ7kOoI4+m9ep60HzYnPhV/HfQr2bvs0L2uAIvL1/+G8pQSjzYiOA== Received: from smtpclient.apple (unknown [IPv6:2001:19f0:6001:9db:98f0:9fe0:3545:10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z1XyN05w7zQCN; Mon, 24 Feb 2025 07:52:27 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: buildkernel failure in net/toeplitz.c (commit 3b281d1421a78b588c5fc4182009ce62d8823d95) From: Zhenlei Huang In-Reply-To: <4858aa49-f102-49fc-90c7-9bd7480306c9@gmail.com> Date: Mon, 24 Feb 2025 15:52:14 +0800 Cc: FreeBSD Current , Gleb Smirnoff , Mark Johnston Content-Transfer-Encoding: quoted-printable Message-Id: References: <4858aa49-f102-49fc-90c7-9bd7480306c9@gmail.com> To: Ian FREISLICH X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Feb 24, 2025, at 12:42 PM, Ian FREISLICH = wrote: >=20 > Hi >=20 > Building a kernel today failed with: >=20 > -Werror /usr/src/sys/net/toeplitz.c > In file included from /usr/src/sys/net/toeplitz.c:29: > In file included from /usr/src/sys/net/rss_config.h:33: > /usr/src/sys/netinet/in.h:692:23: error: call to undeclared function = 'htonl'; ISO C99 and later do not support implicit function declarations = [-Werror,-Wimplicit-function-declaration] > 692 | return (in.s_addr =3D=3D htonl(INADDR_BROADCAST) || > | ^ > In file included from /usr/src/sys/net/toeplitz.c:32: > In file included from /usr/src/sys/sys/systm.h:98: > /usr/src/sys/sys/param.h:343:13: error: conflicting types for 'htonl' > 343 | __uint32_t htonl(__uint32_t); > | ^ > /usr/src/sys/netinet/in.h:692:23: note: previous implicit declaration = is here > 692 | return (in.s_addr =3D=3D htonl(INADDR_BROADCAST) || >=20 > I think this is a result of changes to netinet/in.h (3b281d1421a78) = which added a static inline function using ntohl() which is not defined = in kernel use. >=20 > Ian >=20 May you please have a try with this patch ? ``` diff --git a/sys/netinet/in.h b/sys/netinet/in.h index 0925e3aa7669..4dad4e4fed4d 100644 --- a/sys/netinet/in.h +++ b/sys/netinet/in.h @@ -689,8 +689,8 @@ void in_ifdetach(struct ifnet *); static inline bool in_broadcast(struct in_addr in) { - return (in.s_addr =3D=3D htonl(INADDR_BROADCAST) || - in.s_addr =3D=3D htonl(INADDR_ANY)); + return (in.s_addr =3D=3D INADDR_BROADCAST || + in.s_addr =3D=3D INADDR_ANY); } ``` The `htonl` is pointless here, as INADDR_BROADCAST is all 1s, and = INADDR_ANY is all 0s. Best regards, Zhenlei