From nobody Sun Aug 17 23:17:55 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c4sFx1547z64Bgj for ; Sun, 17 Aug 2025 23:17:57 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c4sFx0NPXz3l5f; Sun, 17 Aug 2025 23:17:57 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755472677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=imWcQ2vt/Kdc2dBXDQPBbBqlN47MFPXqMCB0Hya/thU=; b=xuNFH6kWBaTsxRodUV2dQBLn5+PIvL/TRTPF5haE6APWZe1BN9ghA51DmVspQuRCrolTg9 7CvSA5efUFW1rKkm6vyoB5vCtnSDRcLqrSPJeQu8ISDsfa2+ohg8Wxe2Jd8RO5dYXuNfZb P8raKD605H+wUwiVG7szsvkl2yD//35is90pKAquneQwiaslmncepI4Mbav4t5BgxhbVQC oSdmpLrqZgLKpjKZUXqOiSk3EpL76Vz3L6xUBqLkTbNxCvKkiy635sgSqATpecUXDGiaJb dZ0ZX6p+JlCn9Ix1DAFFxdwQz6hOUMIHzGV1PHgoUNp7BUIsI3KKZLeOn8Jrmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755472677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=imWcQ2vt/Kdc2dBXDQPBbBqlN47MFPXqMCB0Hya/thU=; b=WgbbDHUa7a3hI25sqgoYCTEFAkleSHBX83tCY8I01moIbgstEsUCNUDg//P2eDlHopsQpZ LsNbOjnDxY6BoZmEtRbMcHll4xt0XSplg5l4jD/0Uhhe7Qk2WBguECoQNfzEE6YXM+Ug7Q LFazQwT3Are0Kbb77gX5Fmda6BLfdMImDYaxXU96brKIKk/+H48boEO+WGgKlChLY5geb3 QLr3T5nBjjQtMZtrl8GiXLSAWhLybY/0xL6qHZlqfBhsmZv764azv88WBmOh9JHYzAHhf9 jeZ/Ukma5DUTALVXpqZGz3+HdBB/ApqIMRiDkSQ6NSn6VcsYiDbabt0QQ2K9Og== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755472677; a=rsa-sha256; cv=none; b=VzFnR3LaAvQZoFLvXzVfzy/qUUZEcWZtYXarTfk28AiS4fmecUPZINIgk9gk77gdPZaJBA w43NopzH+9DZfcpAHtb/3z5L/T389kBEloytfy8EMY/T1+SELr17LtEHKoGUFmC+wmcenq M2IlKWKc4ewpwtOJ8rpuwaDBdMgFXTV733gbbZjL1OthR3JKKFhV1ne6EwIDtBxTpBe8vU qsemoZ64lTqtLWMQ+0sOmsHsdrY/2N3bz0k0uL2uK0z2cdTrIU3+dENHg7+5d7V4zy04Pp WejXX8GrVoov/qRfTxW91kuA4S7/BVyACz2XiTfQv35dufSKW6lPSsYCs4sjOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ltc.des.dev (unknown [IPv6:2a01:e0a:c54:bed0:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c4sFw6D1kz5gp; Sun, 17 Aug 2025 23:17:56 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id AB8023BF2A; Mon, 18 Aug 2025 01:17:55 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Bakul Shah Cc: FreeBSD Current Subject: Re: vfs: Assert that st_rdev is NODEV for non-devices In-Reply-To: (Bakul Shah's message of "Sun, 17 Aug 2025 15:54:08 -0700") References: User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 18 Aug 2025 01:17:55 +0200 Message-ID: <86o6sdczbw.fsf@ltc.des.dev> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bakul Shah writes: > etcupdate panics since this commit: > [...] > #13 0xffffffff80c97cb5 in kern_statat (td=3D0xfffff8007e7fc000, > flag=3D, fd=3D, path=3D0x19e4d3242358 "= /usr/src", > pathseg=3DUIO_USERSPACE, sbp=3D0xfffffe0054050d18) > at /home/FreeBSD/current/sys/kern/vfs_syscalls.c:2574 Which filesystem is /usr/src on? If by any chance you are using openzfs from ports, please either switch back to base or try the attached patch. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-filesystems-openzfs-kmod-Set-rdev-to-NODEV-not-0-on-.patch From 7d6691b4d31706d68a58b2e4f937989fae86ce6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dag-Erling=20Sm=C3=B8rgrav?= Date: Mon, 18 Aug 2025 01:14:02 +0200 Subject: [PATCH 1/1] filesystems/openzfs-kmod: Set rdev to NODEV, not 0, on non-devices --- filesystems/openzfs-kmod/Makefile | 1 + .../files/patch-os_freebsd_zfs_zfs__ctldir.c | 11 +++++++++++ .../files/patch-os_freebsd_zfs_zfs__vnops__os.c | 11 +++++++++++ 3 files changed, 23 insertions(+) create mode 100644 filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__ctldir.c create mode 100644 filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__vnops__os.c diff --git a/filesystems/openzfs-kmod/Makefile b/filesystems/openzfs-kmod/Makefile index 7d60ccbd1dbf..2232bc62a2c7 100644 --- a/filesystems/openzfs-kmod/Makefile +++ b/filesystems/openzfs-kmod/Makefile @@ -1,5 +1,6 @@ PORTNAME= openzfs PORTVERSION= 2.3.3 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= filesystems sysutils MASTER_SITES= https://github.com/openzfs/zfs/releases/download/zfs-${PORTVERSION}/ diff --git a/filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__ctldir.c b/filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__ctldir.c new file mode 100644 index 000000000000..b1f16a13b81e --- /dev/null +++ b/filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__ctldir.c @@ -0,0 +1,11 @@ +--- os/freebsd/zfs/zfs_ctldir.c.orig 2025-06-19 16:34:36 UTC ++++ os/freebsd/zfs/zfs_ctldir.c +@@ -494,7 +494,7 @@ zfsctl_common_getattr(vnode_t *vp, vattr_t *vap) + + vap->va_uid = 0; + vap->va_gid = 0; +- vap->va_rdev = 0; ++ vap->va_rdev = NODEV; + /* + * We are a purely virtual object, so we have no + * blocksize or allocated blocks. diff --git a/filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__vnops__os.c b/filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__vnops__os.c new file mode 100644 index 000000000000..6121acd043f2 --- /dev/null +++ b/filesystems/openzfs-kmod/files/patch-os_freebsd_zfs_zfs__vnops__os.c @@ -0,0 +1,11 @@ +--- os/freebsd/zfs/zfs_vnops_os.c.orig 2025-06-19 16:34:36 UTC ++++ os/freebsd/zfs/zfs_vnops_os.c +@@ -1911,7 +1911,7 @@ zfs_getattr(vnode_t *vp, vattr_t *vap, int flags, cred + if (vp->v_type == VBLK || vp->v_type == VCHR) + vap->va_rdev = zfs_cmpldev(rdev); + else +- vap->va_rdev = 0; ++ vap->va_rdev = NODEV; + vap->va_gen = zp->z_gen; + vap->va_flags = 0; /* FreeBSD: Reset chflags(2) flags. */ + vap->va_filerev = zp->z_seq; -- 2.50.1 --=-=-=--