From nobody Thu Apr 24 14:10:24 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZjyYg4KKLz5tM6F for ; Thu, 24 Apr 2025 14:10:47 +0000 (UTC) (envelope-from dch@skunkwerks.at) Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZjyYf4RZFz3KG0; Thu, 24 Apr 2025 14:10:46 +0000 (UTC) (envelope-from dch@skunkwerks.at) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=skunkwerks.at header.s=fm1 header.b=vxMj8rSH; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="G KfqPfi"; dmarc=pass (policy=reject) header.from=skunkwerks.at; spf=pass (mx1.freebsd.org: domain of dch@skunkwerks.at designates 202.12.124.145 as permitted sender) smtp.mailfrom=dch@skunkwerks.at Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 0E33411400ED; Thu, 24 Apr 2025 10:10:45 -0400 (EDT) Received: from phl-imap-16 ([10.202.2.88]) by phl-compute-02.internal (MEProxy); Thu, 24 Apr 2025 10:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skunkwerks.at; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1745503844; x=1745590244; bh=n0kzCJZvxUKIvE2Nu0ba+lZwtU3eWmZM LQSVz41F67k=; b=vxMj8rSHFRAcBa6rzUzh8zMGIrrd4mNWnSDKND71E5Qhr2US 7GEkr5LP+meRJjDbXWDfDbW/1n11NVORLfwCZsnx96KLBguRUOwMU4LeB6Bb5EkP JICmzbrXtjBmD80+XG1fOpo0mOqIEbQ328gWccUr65nmXv3oKKIwokvn7me6O4UZ ThwPd6pWbZm30EYqn/4oTKgPsOYLby9OZ3vqvxhKXIfq1j5ydzF0IkN4BD8lgbXX reBsUfzfDZRXhChqSkY2sgYoyoKAwEa/cDB6k37TFIUdXGH33y3OoD3oY4LTduNK dPM09Ep4HaWriNa77zM/JGc+bu65kUij6VbVsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1745503844; x= 1745590244; bh=n0kzCJZvxUKIvE2Nu0ba+lZwtU3eWmZMLQSVz41F67k=; b=G KfqPfiAujwVPC82W/l68/MmDBOVsKgqF3ihNWP4UP2RKUNrc7CnCgtnPHEeuN9qM EAvMt8cYB40ZaM1fkhOrvV+RIRZIiLBsDN2Mlc1E3A+hHQeuxtqwtbdau32Wh941 wcfopaJzCjT7G4t/7qzhg+jqozjO0FLbf6Q+7Tnz13ooBxeDR3Iu1RH5pl4oMbDQ PckE0N10JIU4yPu1Be0NoiTUuIVwyDWJlFoH7uCWoZoB6C5FoQYER8RJULgL2yhb +kfTeU6yaoGC0YEcwtbGnpb1t/FGeNeO+8UwL7qS3+UZZ+MJ4P3FayiGfTEq2OZ5 HL54tXLf3c8zFJZbYZ5BA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeelieejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefogg ffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdffrghvvgcuvehothht lhgvhhhusggvrhdfuceouggthhesshhkuhhnkhifvghrkhhsrdgrtheqnecuggftrfgrth htvghrnhepieffhfdujeelieekueehgfeigeekleeljeeigefgudeuheetgfdtgeffieev uedvnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepuggthhesshhkuhhnkhifvghrkhhsrdgr thdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepih hmphessghsughimhhprdgtohhmpdhrtghpthhtohepfhhrvggvsghsugdqtghurhhrvghn thesfhhrvggvsghsugdrohhrghdprhgtphhtthhopehglhgvsghiuhhssehfrhgvvggssh gurdhorhhg X-ME-Proxy: Feedback-ID: ic0e84090:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id A837C2CC006A; Thu, 24 Apr 2025 10:10:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 X-ThreadId: T7d8fb190958b0cc3 Date: Thu, 24 Apr 2025 14:10:24 +0000 From: "Dave Cottlehuber" To: "Warner Losh" , "Gleb Smirnoff" Cc: freebsd-current Message-Id: In-Reply-To: <447332f8-a8bc-4b90-a605-4c705a58f491@app.fastmail.com> References: <447332f8-a8bc-4b90-a605-4c705a58f491@app.fastmail.com> Subject: Re: April 2025 stabilization week Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-2.97 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.996]; DMARC_POLICY_ALLOW(-0.50)[skunkwerks.at,reject]; R_SPF_ALLOW(-0.20)[+ip4:202.12.124.128/27:c]; R_DKIM_ALLOW(-0.20)[skunkwerks.at:s=fm1,messagingengine.com:s=fm3]; NEURAL_SPAM_SHORT(0.11)[0.111]; RCVD_IN_DNSWL_LOW(-0.10)[202.12.124.145:from]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[messagingengine.com:dkim]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[dch]; RCVD_COUNT_THREE(0.00)[3]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[skunkwerks.at:+,messagingengine.com:+] X-Rspamd-Queue-Id: 4ZjyYf4RZFz3KG0 X-Spamd-Bar: -- On Thu, 24 Apr 2025, at 14:04, Dave Cottlehuber wrote: > On Mon, 21 Apr 2025, at 14:22, Warner Losh wrote: >> Please note: Gleb is on vacation this week, so I'll be coordinating >> stab-week this time. Please be sure to cc me on any problems you >> encounter. > from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286045 Darius > suggested guarding sc->intr_handler, and with that > https://bugs.freebsd.org/bugzilla/attachment.cgi?id=259480&action=diff > I can boot successfully again: > > THREAD_SLEEPING_OK(); > error = iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actual); > THREAD_NO_SLEEPING(); > if (error == 0) { > if (sc->power_on) { > if (actual != 0) > L#635 ********** sc->intr_handler(sc->intr_ctx, sc->intr_buf, > actual); > else > DPRINTF(sc, "no data received\n"); > } > } else > DPRINTF(sc, "read error occurred: %d\n", error); > > iicbus_release_bus(parent, sc->dev); > } > > I have no idea why/how we get to here with null sc->intr_handler though. > > A+ > Dave workaround below: From 2f8ea6473c2ece8387691a950b8f9e9ec7b8f8bf Mon Sep 17 00:00:00 2001 From: Dave Cottlehuber Date: Fri, 11 Apr 2025 22:24:07 +0000 Subject: [PATCH] iichid: panic --- sys/dev/iicbus/iichid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index b86858791a4d5c4ef790ce4ca0761a2af85a5142..88706ecf460c6f3ca6e8e317a28df220bdad0b97 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -631,7 +631,7 @@ iichid_intr(void *context) THREAD_NO_SLEEPING(); if (error == 0) { if (sc->power_on) { - if (actual != 0) + if ((actual != 0) && (sc->intr_handler != NULL)) sc->intr_handler(sc->intr_ctx, sc->intr_buf, actual); else