From nobody Sun Apr 06 00:45:42 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZVYY70thdz5scW8 for ; Sun, 06 Apr 2025 00:45:47 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZVYY61pGhz44RS for ; Sun, 06 Apr 2025 00:45:46 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b="L/MjaAzI"; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::133 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3d5e68418b5so27387225ab.2 for ; Sat, 05 Apr 2025 17:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1743900345; x=1744505145; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SjYj//ZsGspWp3Qjko/S/5C2N87nLkAjp1wxzc/Ci54=; b=L/MjaAzIDoKnx3xUzYQ4NbgrG+diEzVLEXIvI5mZO88sRtI2FwqoxRBCVFtHZKrHQs 3jA9JT1DbyL2zZ3F7HOdULsTM3BTeZHKFObTolllZ/yzeMLSabs4l56TsubH7DiY7nvu goTV/dgyfm92bB0Cm/ptP8F8LhlcdjMTFz9Yba1HRdGAzVR7QbVxotSuwQq7TgUBXkmP ueg+LeCeHgFx52lqA9ZzaCEuAmfTTdMXQApBvsTzI1EfwHKyiecPTthFn73en+lfZSjG q2wELkONMv3TiD3TfAn4r5+nK9fHFfC3d9yFfVy+aBeS2PxzjemtYd31LOa7Wb/FP2Dr YrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743900345; x=1744505145; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SjYj//ZsGspWp3Qjko/S/5C2N87nLkAjp1wxzc/Ci54=; b=HA0p5rRpuyTJZHz0kPbu7FwvKwt/djKhz1n3FN+sAN8KPsKXh+eNVFlAXlFafoNNjp 54/9AKN49W6ITHvHNN3KZlbyq5lA9GNw0ZhwfuHnX9AQrTIXr43bTunE7Jx1AbsOKUhM pncQ/OmPa57ZUEgWl3T6NXzbXOjDkOJsvHNB6E8IA2PkfoUdhrmpoHkqw+/YdeN6b6xw 3WLbLn0gyCWYCPeqQyJHVvLKX5ZREKOVspnSsby7QT7FDV9TkhsFlf75eDy1GLES9ISG jZ8UNQ6dbJCvcd2auIOEM29dmGgBeslPkW5ZTSs5Ug473/ABuspMoXOHbXrwqRlg/LBY FP6g== X-Gm-Message-State: AOJu0YyV3Sj7D2wqXRjZuEpSRpwnYX0bcVT8yeIrwsYWa3NSd5WiUH9A QFid/WVjahLMUXXEi0+C7Xfvt6NshxtY/nM8uToZmL+pCXzsk7HXS2rOFKlyo3s= X-Gm-Gg: ASbGnctcp7s5ff9flGZhPpduCGbXhiJpG6KjajclM0wSbTm7ViB+OpCVFm+ioeQUtD6 pjrW5A1pBDZGQcN0P1Jlss9hCf6fj2spiA8ceSaDGStTdeRSVLiZWJ77jhyUtNvzGp38iAAMTyj bCp1vzU6BliR9wqImd8JgE5p/iiwnQk4R3BCHOR20LoiM07DuYjZ3sHa8476wi/cP+e6zXr0LS9 RookNCC5CSpqR8YF/389XItRbIlj43wv1uBXtL64Abat1+zSf1Tw0Z1jz4kd2SjHsHbZzUY4omp gEZcVZf43ePc+xL9kCd57uhE32U= X-Google-Smtp-Source: AGHT+IF8bNszaLnTUgxJF0XkjGg5Qu+YAz662Y2f1CcFU3IMHUorjepi4pXu/oAbCNqV3Bw+yyGbqA== X-Received: by 2002:a05:6e02:1647:b0:3cf:fe21:af8 with SMTP id e9e14a558f8ab-3d6ec52ce51mr43688365ab.4.1743900344847; Sat, 05 Apr 2025 17:45:44 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d6de973f87sm16098055ab.64.2025.04.05.17.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Apr 2025 17:45:44 -0700 (PDT) Date: Sun, 6 Apr 2025 00:45:42 +0000 From: Shawn Webb To: Rick Macklem Cc: FreeBSD CURRENT Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.2-STABLE-HBSD FreeBSD 14.2-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <2rq3bpvhclcipvgg3mo4gml7ysuzbvt6rfnzkprceumzeaeh4b@casrpprm6mgt> <4beaxy5dpajikvafxpjogcxrpyuwwicng5ln5rxbxlbzp2o2g7@ib7wo5jzlte4> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zpqccct4cm4pmrbf" Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-4.82 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.72)[-0.718]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; DMARC_NA(0.00)[hardenedbsd.org]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MISSING_XM_UA(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::133:from] X-Rspamd-Queue-Id: 4ZVYY61pGhz44RS X-Spamd-Bar: ---- --zpqccct4cm4pmrbf Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main MIME-Version: 1.0 On Sat, Apr 05, 2025 at 05:36:07PM -0700, Rick Macklem wrote: > On Sat, Apr 5, 2025 at 4:43=E2=80=AFPM Shawn Webb wrote: > > > > On Sat, Apr 05, 2025 at 04:12:15PM -0700, Rick Macklem wrote: > > > On Sat, Apr 5, 2025 at 9:12=E2=80=AFAM Shawn Webb wrote: > > > > > > > > On Sat, Apr 05, 2025 at 08:52:06AM -0700, Rick Macklem wrote: > > > > > On Sat, Apr 5, 2025 at 8:50=E2=80=AFAM Rick Macklem wrote: > > > > > > > > > > > > On Fri, Apr 4, 2025 at 6:27=E2=80=AFPM Shawn Webb wrote: > > > > > > > > > > > > > > On Sat, Apr 05, 2025 at 01:04:25AM +0000, Shawn Webb wrote: > > > > > > > > On Fri, Apr 04, 2025 at 05:40:21PM -0700, Rick Macklem wrot= e: > > > > > > > > > On Fri, Apr 4, 2025 at 10:50=E2=80=AFAM Shawn Webb wrote: > > > > > > > > > > > > > > > > > > > > On Thu, Apr 03, 2025 at 06:12:59PM -0700, Rick Macklem = wrote: > > > > > > > > > > > On Thu, Apr 3, 2025 at 4:52=E2=80=AFPM Shawn Webb wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Apr 02, 2025 at 01:51:26PM -0700, Rick Mack= lem wrote: > > > > > > > > > > > > > The commit 2ec2ba7e232d just hit main. I do not = think it will > > > > > > > > > > > > > cause problems, but it is fairly large. > > > > > > > > > > > > > > > > > > > > > > > > > > Man page updates will be done as separate commits. > > > > > > > > > > > > > > > > > > > > > > > > > > Hopefully this will not cause grief, rick > > > > > > > > > > > > > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > > > > > > > > > > > > > The patch review test plan mentions a patch to ZFS = itself to support > > > > > > > > > > > > named attributes. Is that patch available somewhere? > > > > > > > > > > > The ZFS patch is currently in phabricator as D49654. > > > > > > > > > > > Feel free to review it. > > > > > > > > > > > > > > > > > > > > > > It can also be found at: > > > > > > > > > > > https://people.freebsd.org/~rmacklem/zfs-xattr.patch > > > > > > > > > > > (this is a smaller diff which can be applied to an up= -to-date main src > > > > > > > > > > > tree easily) > > > > > > > > > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > > > > > > > > > I applied that zfs patch, but trying pathconf(2) on a f= ile on a ZFS > > > > > > > > > > dataset with xattr=3Don (which seems to be the default)= returns 0. Am I > > > > > > > > > > doing something wrong? > > > > > > > > > > > > > > > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > > > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ ./xattrtest xa= ttrtest > > > > > > > > > > xattrtest: Named attributes not enabled: No error: 0 > > > > > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp (1) $ zfs list /= usr/home/shawn > > > > > > > > > > NAME USED AVAIL REFER MOUNTPOINT > > > > > > > > > > rpool/usr/home 10.4G 71.4G 9.85G /usr/home > > > > > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ zfs get xattr = rpool/usr/home > > > > > > > > > > NAME PROPERTY VALUE SOURCE > > > > > > > > > > rpool/usr/home xattr on default > > > > > > > > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > > > > > > > > > > > > > > > That xattrtest application is yours from: > > > > > > > > > > https://people.freebsd.org/~rmacklem/xattrtest.c > > > > > > > > > No idea. It works for me. You used up-to-date kernel sour= ces? > > > > > > > > > (Check that VIRF_NAMEDATTR is defined in sys/sys/vnode.h.) > > > > > > > > > Oh, and one more thing to check. zfs_xattr_compat needs t= o be non-zero. > > > > > > > > > (It's found in sys/contrib/openzfs/module/os/freebsd/zfs/= zfs_vnops_os.c. > > > > > > > > > It's initialized to 1 and I don't see anything that sets = it to 0?) > > > > > > > > > > > > > > > > It is indeed set to 1. > > > > > > > > > > > > > > > > > > > > > > > > > > The only thing I can think if is, if you changed xattr to= on, you need to > > > > > > > > > reboot (or at least remount) to get it to take effect. > > > > > > > > > (Maybe try setting it to "dir" and then reboot/remount. M= aybe there is > > > > > > > > > a difference between "on" and "dir"?) > > > > > > > > > > > > > > > > Yeah, tried rebooting and still no go. Note that xattr defa= ults to > > > > > > > > "on" in FreeBSD by default. My src tree is synced up to Fre= eBSD commit > > > > > > > > 7e70d94acd68b3ac6b45f49d4ab7a0f7867c3ea7. I brought in the = ZFS patch > > > > > > > > you linked to. > > > > > > > > > > > > > > > > > > > > > > > > > > Or, did you build zfs.ko some other way than as part of a= kernel build? > > > > > > > > > (It needs the patched .h files in the kernel sources, not= something in > > > > > > > > > /usr/include/sys > > > > > > > > > that has not yet been updated.) > > > > > > > > > All the ZFS changes are #ifdef'd, since OpenZFS requires = the sources > > > > > > > > > build for older kernels. (Basically #ifdef'd on that VIRF= _NAMEDATTR mentioned > > > > > > > > > above.) > > > > > > > > > > > > > > > > Perhaps I need to do a clean build. I'll try that and repor= t back. > > > > > > > > > > > > > > > > > > > > > > > > > > It does remind me that I need to try a build of zfs.ko by= doing a "make" in > > > > > > > > > the module directory. > > > > > > > > > > > > > > > > > > You can try the attached trivial patch and see if it spit= s out "pathconf ret=3D1" > > > > > > > > > on the console. > > > > > > > > > > > > > > > > I'll try that after a clean rebuild of the kernel. > > > > > > > > > > > > > > Clean rebuild didn't resolve it. However, I made some progres= s. > > > > > > > > > > > > > > I created a dataset specifically for this since I can't reall= y unmount > > > > > > > my /usr/home dataset, so my example down below is a bit diffe= rent than > > > > > > > the previous example I gave. > > > > > > > > > > > > > > The xattr property is set to "on" for the dataset. However, i= t's not > > > > > > > mounted with the xattr property. In order to get it to work, = I had to > > > > > > > run the following commands: > > > > > > > > > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > > > > > $ sudo zfs umount rpool/scratch/xattr > > > > > > > $ sudo mount -t zfs -o xattr rpool/scratch/xattr /scratch/xat= tr > > > > > > > $ zfs get xattr rpool/scratch/xattr > > > > > > > NAME PROPERTY VALUE SOURCE > > > > > > > rpool/scratch/xattr xattr on local > > > > > > > $ mount | grep xattr > > > > > > > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, n= fsv4acls, named attributes) > > > > > > > $ mount | grep named > > > > > > > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, n= fsv4acls, named attributes) > > > > > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > > > > > > > > > So it looks like FreeBSD does not honor the xattr zfs propert= y, > > > > > > > otherwise you would see a whole bunch of datasets mounted wit= h the > > > > > > > "named attributes" flag in that last `mount | grep` command. > > > > > > I've looked at this a little more... > > > > > > There is a function xattr_changed_cb() that updates the xattr p= roperty > > > > > > information. > > > > > > It gets called when "zfs set xattr=3DXX " is done = or when > > > > > > the mount option "xattr" is set. > > > > > > > > > > > > The question seems to be "Why was the stuff not correctly set f= or your file > > > > > > systems, although they show xattr=3Don?" > > > > > > > > This is indeed what I was inferring. xattr has been set to "on" sin= ce > > > > the pool's creation as far as I can tell. Until experimenting with > > > > your patch, I didn't really even know the xattr property even exist= ed. > > > I was able to reproduce this with a fresh zpool. > > > Although it reported "xattr on", that is not really accurate. > > > > > > I stuck a printf() in here (line#853-861 of > > > sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.) > > > > > > /* should either have both of these objects or none */ > > > error =3D zap_lookup(os, MASTER_NODE_OBJ, ZFS_SA_ATTRS, 8, 1, > > > &sa_obj); > > > if (error !=3D 0) > > > return (error); > > > > > > error =3D zfs_get_zplprop(os, ZFS_PROP_XATTR, &val); > > > --> The printf here shows that error =3D=3D ENOENT. > > > if (error =3D=3D 0 && val =3D=3D ZFS_XATTR_SA) > > > zfsvfs->z_xattr_sa =3D B_TRUE; > > > > > > The printf() of error showed ENOENT. So, "xattr" actually does not > > > exist. "zfs get xattr " calls it "on" but that's not acc= urate. > > > > > > As root, I did: > > > # zfs set xattr=3Ddir > > > - reboot > > > > > > This makes it work, although the above call still returns ENOENT. > > > It looks to me like zfsvfs_init() gets called from zfsvfs_create() > > > right at the beginning of zfs_domount(). > > > Later in zfs_domount() it calls zfsvfs_setup()->zfs_register_callback= s(), > > > which now finds the property (because of the "zfs set xattr=3Ddir ") > > > and registers it via dsl_prop_register(). > > > > > > I don't know if the above is correct? > > > Personally, I would prefer to see "zfs get xattr " reply= "not set" > > > instead of "on". > > > > > > rick > > > > > > > > > Setting the property makes it work, but only after rebooting > > > (a umount/mount would probably have the same effect, I think?). > > > > So I wonder why neither an unmount/mount nor a reboot causes `mount | > > grep "named attribute"` to fail for me. HardenedBSD doesn't have any > > changes to ZFS that would cause that kind of behavior. I have to > > unmount, but manually mount with `mount -t zfs -o xattr ...` in order > > to access the new feature you wrote. Weird. > So, you have done > # zfs set xattr=3Ddir > followed by a reboot and it still doesn't work? Correct, even a reboot does not work. --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --zpqccct4cm4pmrbf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmfxzq4ACgkQ/y5nonf4 4foMnw/+PFbtPvbjr9hrbcfh/ImD3hwv5Ce/asf5okdXEsd/rdMGqeTKzGnOCGmU 3AA3YrGUlFtda0P76Lj2HhlQ4TRyW1sTus0cvOsvdOGjK22vGG3wdd+kahPNk5qu VkONulI9Zg7fCS+MUXZuVSCEeF87oq1wT0ged0PyM4diuAeMFrl6vAI+zYV9gCQO SgvX30cjOL8sWLPlQcayNyijCt3XV1gRpFE+1nzOabVpVyscSPa91Rp8Ckyn/fnk dGoPbUNVQH4Y3Zj8RH32Ikz5fnfr5VQbmdRonLoO+PAvX5WhQNplB8I8EkWThfIJ FTdeVvLGDdthPNytC5tXNs16h8rUggTZD9+Al87ZNQTugTNwoOrPeS/5Ostm/gfV kW+O9lJza/UvAw+Ecap5E9inYlqkVZY1Mbwb3xC/ZMpOQ5lIE+D8r3pGZmrtTyHN 6Mc3yScIKI/INmnIY9nBF2UUM6HAN/GIZ0RKkVfUOoRN9tRXcdvHw02Up/3U+fQX x6k9xHIMJi+D2CAMU/4pfEJf9UhGs86uHtnx2v/AWZa4dvCtTYwxFvoFJWcfdz+X T8Us2JrIXHZadwv6+ShUh2MEOfnbB7M1GqGnL1SagXgPJJI/Ewfx0RRw9bzfWA0O P75h/HD2Ha41vKpQ3jT9SIRfTtQqq3WMMsb2DeyljANX0QjefQY= =PLiI -----END PGP SIGNATURE----- --zpqccct4cm4pmrbf--