From nobody Wed Nov 09 21:31:41 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N6ypY1qq7z4dD6q for ; Wed, 9 Nov 2022 21:31:49 +0000 (UTC) (envelope-from Alexander@leidinger.net) Received: from mailgate.Leidinger.net (mailgate.leidinger.net [IPv6:2a00:1828:2000:313::1:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature ECDSA (P-256)) (Client CN "mailgate.leidinger.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N6ypY01gXz4R1j; Wed, 9 Nov 2022 21:31:49 +0000 (UTC) (envelope-from Alexander@leidinger.net) Authentication-Results: mx1.freebsd.org; none Received: from outgoing.leidinger.net (p508d4280.dip0.t-ipconnect.de [80.141.66.128]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) client-signature ECDSA (P-256)) (Client CN "outgoing.leidinger.net", Issuer "R3" (verified OK)) by mailgate.Leidinger.net (Postfix) with ESMTPSA id D4EC922B1C; Wed, 9 Nov 2022 22:31:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1668029503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KozT+rcAvDcrRuaYsO0BAsh82TsmKP4UDnCM/YXfHPI=; b=Tcjf3U/IEPs4YgV9KfsdtWE94kYdJqkYsU/p0lfVCmlQKL/twKlw4alsTI8WZV5rozkoDd tYe0/S1gX6JjexYjHwWpAOeCDxu2IGl/rOOG4l4MbsNwECoSM1JPTeY7qhZAxXV59S45Ui 9q2JakIXPK4bavtcJDFYv/JwCCQyGLHQPFIzmqveIXJGnihPKc5vjq8Dm2BILPS4kIRQjf qVZ+xcc/goCLbE0S3J+nYhGZjCgWnRsRatI+tJ89sXqcH1IuApUDATpWlQurzbbjZxbirW 6PACWCTC74uO9Bt9MVORs35rpRD+2P/VJyB70z+b84fzMLFYB4+y4NVzgbw/xQ== Received: from webmail.leidinger.net (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (Client did not present a certificate) by outgoing.leidinger.net (Postfix) with ESMTPS id 6E4CA34A4; Wed, 9 Nov 2022 22:31:41 +0100 (CET) Date: Wed, 09 Nov 2022 22:31:41 +0100 Message-ID: <20221109223141.Horde.nBWydmiH2iSoYq79Rb8jk38@webmail.leidinger.net> From: Alexander Leidinger To: Brooks Davis Cc: Mark Millard , "Patrick M. Hausen" , Warner Losh , tsoome@freebsd.org, Li-Wen Hsu , current@freebsd.org Subject: Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script) References: <20221108105053.Horde.eqgFiBJe2ngGAj6BkXcv5-Z@webmail.leidinger.net> <20221109134610.Horde.JB7ibQTWprHbmIUfhg7JY7f@webmail.leidinger.net> <460205F9-5D59-4033-813B-C34E01BFD6C4@hausen.com> <20221109204509.Horde.lh5parVrWDSJ7kQCFa64hqe@webmail.leidinger.net> <5AFBB434-BB3B-4B5A-AB32-11DAFD03A2AD@hausen.com> <20221109205846.Horde.Rm5dcHB7p4mSbfFmxReYEDW@webmail.leidinger.net> <671B1F82-A167-45D0-8BCC-4717F433BC11@yahoo.com> <20221109211947.Horde.F4xwQw3LUvp0P2aLceiZdwf@webmail.leidinger.net> <20221109211841.GC95557@spindle.one-eyed-alien.net> In-Reply-To: <20221109211841.GC95557@spindle.one-eyed-alien.net> Accept-Language: de,en Content-Type: multipart/signed; boundary="=_60q9Fa6oz_uZKdKGB16_EF6"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 X-Rspamd-Queue-Id: 4N6ypY01gXz4R1j X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:34240, ipnet:2a00:1828::/32, country:DE] X-ThisMailContainsUnwantedMimeParts: N This message is in MIME format and has been PGP signed. --=_60q9Fa6oz_uZKdKGB16_EF6 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Brooks Davis (from Wed, 9 Nov 2022=20=20 21:18:41=20+0000): > On Wed, Nov 09, 2022 at 09:19:47PM +0100, Alexander Leidinger wrote: >> Quoting Mark Millard (from Wed, 9 Nov 2022 >> 12:10:18 -0800): >> >> > On Nov 9, 2022, at 11:58, Alexander Leidinger >> > wrote: >> > >> >> Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 >> >> 20:49:37 +0100): >> >> >> >>> Hi, >> >>> >> >>>> Am 09.11.2022 um 20:45 schrieb Alexander Leidinger >> >>>> : >> >>>> But "zpool set feature@edonr=3Denabled rpool" (or any other feature >> >>>> not in the list we talk about) would render it unbootable. >> >>> >> >>> Sorry, just to be sure. So an active change of e.g. checksum or >> >>> compression algorithm >> >>> might render the system unbootable but a zpool upgrade never will? >> >>> At least not intentionally? ;-) >> >> >> >> If you mean "zpool upgrade", then no (modulo bugs). OpenZFS uses >> >> the feature flags instead of zpool upgrade. >> > >> > I'm confused by that answer: >> >> See my correction in another mail, the behavior seems to have changed >> and yes, doing a zpool upgrade on a boot pool should not be done. >> >> Maybe someone wants to check or add provisions to not do that on a >> pool which has the bootfs property set. > > Literally the entire point of the script added in the commit this thread > is about upgrade the boot pool on first boot so that seems like it would > be counterproductive. Something is missing here. Either some pointer to some safetynet for=20=20 pools=20with the bootfs property set (or a similar "this is a bootable=20= =20 pool"=20flag), or a real-world test of the script. Any brave soul around to spin up a test-VM and perform a "echo before;=20= =20 zpool=20get all rpool | grep feature; zpool upgrade rpool; echo after;=20= =20 zpool=20get all rpool | grep feature" inside? Bye, Alexander. --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_60q9Fa6oz_uZKdKGB16_EF6 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmNsHDwACgkQEg2wmwP4 2IZZXA/+I4O5NnA4VT+pQfBy0XdY94XJz1LYZt5xnbdWbQ8GJKRQ6UIPAGyH+bL7 Lb7je3C5c1s6/S2RWmMqM6FBx/u5BpFtZsF8LwgnhgE+G3YNDtr0w9VY8fJ+Dak9 ivdzlC5G1qWCOpxOy9+5WZUmCarMrdBFLcem/V/DNbnID/WmhF312zXjCwrOk52D ZW3S4fgzXw6QMnnxFS8AkcRn+SsXZ891vxbp/fJ3AlmGlWJD/yhwITu3vlJw/R2Z nUL67qSa60DimcdJbmlJyhl9qE3mh9FbQqho2OfG8QAaoa0tLH4TtsfKXVnhVcwc Py4tLGiTJJ3josaB6zPOFqdD8FnpbJW5WFhJKbEb7r2oC4ySzB6voCQrVe+YHeM+ qndNy7NlG3oTafESrKTgYGedqpUFuZJ6mV4vHAXWT+x+n+fJwxB8370SAXKmowEU ZMjwoaHhETzh8iFHdTEeXiPW3LZrMAwueS52gLRVCHVhb+FoEAHzjIZMOPb4ky3z UGV4FUYh0zhXI8bkZE5uSKxtbGrI04noztMKXy+JaUwZ01MDr7d6tGyTMptpmcL5 msp8kbbAEPGzvcBIGvEvLnFCE+a6koL2B78CBGu0b/FnVDRgMphr62FvX0s3xUnM DPNKXkLntlGazAz8MpcEyM6lRjpAA8E6IiQzy6IgCBy/nr4Limk= =Ig1A -----END PGP SIGNATURE----- --=_60q9Fa6oz_uZKdKGB16_EF6--