[Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Tue Feb 16 05:16:07 UTC 2021
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253158
--- Comment #50 from commit-hook at FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=c31480a1f66537e59b02e935a547bcfc76715278
commit c31480a1f66537e59b02e935a547bcfc76715278
Author: Konstantin Belousov <kib at FreeBSD.org>
AuthorDate: 2021-02-15 03:36:02 +0000
Commit: Konstantin Belousov <kib at FreeBSD.org>
CommitDate: 2021-02-16 05:11:52 +0000
UFS snapshots: properly set the vm object size.
Citing Kirk:
The previous code [before 8563de2f2799b2cb -- kib] did not call
vnode_pager_setsize() but worked because later in ffs_snapshot() it
does a UFS_WRITE() to output the snaplist. Previously the UFS_WRITE()
allocated the extra block at the end of the file which caused it to do
the needed vnode_pager_setsize(). But the new code had already allocated
the extra block, so UFS_WRITE() did not extend the size and thus did not
do the vnode_pager_setsize().
PR: 253158
Reported by: Harald Schmalzbauer <bugzilla.freebsd at omnilan.de>
Reviewed by: mckusick
Tested by: cy
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
sys/ufs/ffs/ffs_snapshot.c | 4 ++++
1 file changed, 4 insertions(+)
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-fs
mailing list