leftovers in fs/msdosfs/msdosfsmount.h

Konstantin Belousov kostikbel at gmail.com
Sat Mar 21 17:13:09 UTC 2015


On Thu, Mar 19, 2015 at 08:49:33PM -0700, Chris Torek wrote:
> I was poking at the kernel-side msdosfs code for reasons too boring :-) to
> go into here and found some stuff that should be safe to remove, based on
> the fact that there are no references to these names anywhere in the rest
> of the entire source tree.
> 
> I've built a kernel with this patch in it (as a double check) but have not
> tested it on anything else.  I don't really care if it goes in or not, I'm
> just providing it since I got misled slightly (in terms of how the UTF-16
> en- and de-coding was to be done) when I was looking at the header.
> 
> (In case gmail eats the straight text patch below, it's here as an
> attachment too.  I'd send from a better mail system but my regular home
> FreeBSD system is still not quite up yet...)
I started the make universe for your patch, will commit after.

> 
> (A more interesting question is: when can the old compat mount stuff go
> away?)

I did the review of the cmount() usage in the base, and I think now it is
the autofs(4) author who is in charge.  It seems that the only user of
cmount in base is amd, and it should be removed, after autofs is mature
enough.


More information about the freebsd-fs mailing list