[PATCH] disable nfsd (NFSv4) nobody/nogroup check

[Marcelo Araujo]

2014-10-16 10:42 GMT+08:00 Marcelo Araujo <araujobsdport at gmail.com>:

>
>
> 2014-10-16 7:46 GMT+08:00 Rick Macklem <rmacklem at uoguelph.ca>:
>
>> Marcelo Araujo wrote:
>> >
>> > Hello Ronald and Blot,
>> >
>> >
>> >
>> > Here is the patch with a small rework. I consider Ronaldo's comments
>> > as well as I just change a bit the code style.
>> >
>> >
>> > If you guys agree with the patch, I will commit it today.
>> >
>> Looks fine to me.
>>
>
> Thanks Rick! Committed; I will do the MFC after two weeks if you have no
> objections.
>
> https://svnweb.freebsd.org/base?view=revision&revision=273159
>
>
>> >
>> > Note: About the disable_utf8 that Rick has mention, I will rework
>> > that part later to make it as enable_utf8 instead of disable_utf8.
>> >
>> If you do change this one, try to include something in the description
>> string w.r.t. RFC-3530 requires it to be enabled.
>>
>> Thanks, rick
>>
>>
> Rick, here is a patch that renames the disable_utf8 to enable_utf8 and as
> per your request, I have changed the description of the sysctl(8) as well.
> Let me know if the change looks good for you as well as the description.
>
>
>
>
Ouch, I forgot to attach the patch, spotted by kevlo@ via Skype :_)


Best Regards,

-- 

-- 
Marcelo Araujo            (__)araujo at FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)
-------------- next part --------------
Index: sys/fs/nfsserver/nfs_nfsdsubs.c
===================================================================
--- sys/fs/nfsserver/nfs_nfsdsubs.c	(revision 273159)
+++ sys/fs/nfsserver/nfs_nfsdsubs.c	(working copy)
@@ -61,10 +61,10 @@
 
 SYSCTL_DECL(_vfs_nfsd);
 
-static int	disable_checkutf8 = 0;
-SYSCTL_INT(_vfs_nfsd, OID_AUTO, disable_checkutf8, CTLFLAG_RW,
-    &disable_checkutf8, 0,
-    "Disable the NFSv4 check for a UTF8 compliant name");
+static int	enable_checkutf8 = 1;
+SYSCTL_INT(_vfs_nfsd, OID_AUTO, enable_checkutf8, CTLFLAG_RW,
+    &enable_checkutf8, 0,
+    "Enable the NFSv4 check for the UTF8 compliant name required by rfc3530");
 
 static int    enable_nobodycheck = 1;
 SYSCTL_INT(_vfs_nfsd, OID_AUTO, enable_nobodycheck, CTLFLAG_RW,
@@ -2005,7 +2005,7 @@
 		    error = 0;
 		    goto nfsmout;
 		}
-		if (disable_checkutf8 == 0 &&
+		if (enable_checkutf8 == 1 &&
 		    nfsrv_checkutf8((u_int8_t *)bufp, outlen)) {
 		    nd->nd_repstat = NFSERR_INVAL;
 		    error = 0;