ext2fs: PR 153584, prealloc, etc.

[Pedro F. Giffuni]

Hello;

--- On Sun, 1/2/11, Doug Barton <dougb at FreeBSD.org> wrote:

> From: Doug Barton <dougb at FreeBSD.org>
> Subject: ext2fs: PR 153584, prealloc, etc.
> To: freebsd-fs at FreeBSD.org
> Cc: "Pedro F. Giffuni" <giffunip at tutopia.com>, "Aditya Sarawgi" <sarawgi.aditya at gmail.com>
> Date: Sunday, January 2, 2011, 9:45 PM
> Howdy,
> 
> Pedro,
> 
> Thanks for http://www.freebsd.org/cgi/query-pr.cgi?pr=153584
> however it does not compile on HEAD:
> 
> cc -O2 -pipe -g -fno-strict-aliasing -Werror -D_KERNEL
> -DKLD_MODULE
> -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS
> -include
> /usr/local/obj/home/svn/head/sys/GENERIC/opt_global.h -I.
> -I@ -I@/contrib/altq -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000
> -fno-common -g -g -fno-omit-frame-pointer
> -I/usr/local/obj/home/svn/head/sys/GENERIC -mcmodel=kernel
> -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2
> -mno-sse3 -mno-mmx -mno-3dnow  -msoft-float
> -fno-asynchronous-unwind-tables -ffreestanding
> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual  -Wundef -Wno-pointer-sign
> -fformat-extensions -c
> /home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c
> /home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c:
> In function 'ext2_checkoverlap':
> /home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c:108:
> error: dereferencing pointer to incomplete type
> *** Error code 1
> 
> Stop in /home/svn/head/sys/modules/ext2fs.
> *** Error code 1
> 

Thanks for the bug report. This will be very easy to fix and I don't know why I didn't see it here. but for now use this simpler patch.

> 
> Any chance you 2 could work together to come up with 1
> patch that has the best of both worlds, and actually
> compiles on HEAD? It would also be really useful if the
> resultant patch was created using 'svn diff' as it would be
> a lot easier for those of us who are interested in testing
> this to do so, not to mention actually getting it
> committed.
> 

We have been working together with Zheng Liu, who did the
preallocation patch, but I believe these fixes should come
first.

Thanks for testing!

Pedro.


      
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-bde
Type: application/octet-stream
Size: 1643 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20110103/a225da8c/patch-bde.obj