PERFORCE change 90095 for review

Robert Watson rwatson at FreeBSD.org
Sat Jan 21 15:36:55 GMT 2006


http://perforce.freebsd.org/chv.cgi?CH=90095

Change 90095 by rwatson at rwatson_sesame on 2006/01/21 15:36:25

	Void '- ... -' expressions, because FlexeLint tells me I will find
	it confusing.
	
	Submitted by:	phk
	Found with:	FlexeLint

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_io.c#22 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_io.c#22 (text+ko) ====

@@ -2372,7 +2372,7 @@
 	int err = 0;
 	int recoversize;
 
-	recoversize = len - tok->len - BSM_TRAILER_SIZE;
+	recoversize = len - (tok->len + BSM_TRAILER_SIZE);
 	if (recoversize <= 0)
 		return (-1);
 
@@ -2737,7 +2737,7 @@
 		bptr += sizeof(u_int32_t);
 
 		/* now read remaining record bytes */
-		bytestoread = recsize - sizeof(u_int32_t) - sizeof(u_char);
+		bytestoread = recsize - (sizeof(u_int32_t) + sizeof(u_char));
 
 		if (fread(bptr, 1, bytestoread, fp) < bytestoread) {
 			free(*buf);
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message



More information about the trustedbsd-cvs mailing list