PERFORCE change 86437 for review

Pawel Jakub Dawidek pjd at FreeBSD.org
Tue Nov 8 11:43:43 GMT 2005


On Mon, Nov 07, 2005 at 09:45:06PM +0000, Todd Miller wrote:
+> http://perforce.freebsd.org/chv.cgi?CH=86437
+> 
+> Change 86437 by millert at millert_ibook on 2005/11/07 21:44:18
+> 
+> 	fix typo introduced in previous rev
+> 
+> Affected files ...
+> 
+> .. //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_av.c#6 edit
+> 
+> Differences ...
+> 
+> ==== //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_av.c#6 (text+ko) ====
+> 
+> @@ -82,7 +82,7 @@
+>  	if (mcl == NULL)
+>  		return 0;
+>  
+> -	cl = msgid-mcl->baseid / (8 * sizeof(access_vector_t));
+> +	cl = (msgid-mcl - >baseid) / (8 * sizeof(access_vector_t));

That's a hard to read line of code:)
I think this is a bit easier:

	cl = (msgid - mcl->baseid) / (8 * sizeof(access_vector_t));

I suppose this was the plan, but you inserted spaces in the wrong place.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/trustedbsd-cvs/attachments/20051108/785209d4/attachment.bin


More information about the trustedbsd-cvs mailing list