PERFORCE change 38799 for review

Robert Watson rwatson at FreeBSD.org
Mon Sep 29 20:56:32 GMT 2003


http://perforce.freebsd.org/chv.cgi?CH=38799

Change 38799 by rwatson at rwatson_tislabs on 2003/09/29 13:55:36

	Make sure to unlock the pipe mutex when a MAC check fails on
	an ioctl, or we might return to userspace still holding the
	pipe mutex.
	
	Tripped over by:	areisse

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/sys_pipe.c#42 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/sys_pipe.c#42 (text+ko) ====

@@ -1233,8 +1233,10 @@
 
 #ifdef MAC
 	error = mac_check_pipe_ioctl(active_cred, mpipe, cmd, data);
-	if (error)
+	if (error) {
+		PIPE_UNLOCK(mpipe);
 		return (error);
+	}
 #endif
 
 	switch (cmd) {
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message



More information about the trustedbsd-cvs mailing list