PERFORCE change 20056 for review

John Baldwin jhb at freebsd.org
Thu Oct 24 18:12:57 GMT 2002


On 24-Oct-2002 Nate Lawson wrote:
> On Thu, 24 Oct 2002, Robert Watson wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=20056
>> 
>> Change 20056 by rwatson at rwatson_tislabs on 2002/10/24 10:53:26
>> 
>>      During the root mount, it's possible for a NULL mountpoint
>>      to be passed to getnewvnode() to support the device vnode
>>      we're mounting on.  For now, just skip setting the
>>      label on these vnodes, and generate a printf to make sure
>>      our understanding of this scenario is correct.  In the
>>      future, we might want to add a KASSERT that the type of
>>      the vnode is "none", or special case the handling here
>>      a bit further.
> 
> I hope you don't mean strcmp(vp->v_tag, "none") and instead mean
> vp->v_type & VNON.

Speaking of v_tag, can you fix the devel/libgtop port on current?
This is the patch I used to get it building the other day:

> cat patch-sysdeps_freebsd_procmap.c 
--- sysdeps/freebsd/procmap.c.orig      Tue Oct 15 20:00:35 2002
+++ sysdeps/freebsd/procmap.c   Tue Oct 15 20:05:54 2002
@@ -251,6 +251,7 @@
                              &vnode, sizeof (vnode)) != sizeof (vnode))
                        glibtop_error_io_r (server, "kvm_read (vnode)");
 
+#if __FreeBSD_version < 500000
                if ((vnode.v_type != VREG) || (vnode.v_tag != VT_UFS) ||
                    !vnode.v_data) continue;
 
@@ -261,6 +262,7 @@
 
                maps [i-1].inode  = inode.i_number;
                maps [i-1].device = inode.i_dev;
+#endif
 #endif
        } while (entry.next != first);

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message



More information about the trustedbsd-cvs mailing list