OpenBSM compiler warnings patch

Robert Watson rwatson at FreeBSD.org
Fri Dec 15 00:25:44 PST 2006


On Sun, 19 Nov 2006, Diego Giagio wrote:

> I've created a patch that removes all the compiler warnings I was getting, 
> mostly signed/unsigned stuff.
>
> bsm_io.c: I've sticked with the following rules to resolve the conflicts:
>
> - Buffers are u_char*
> - Strings are char* (or const char*)
> - Casts are used when pointing strings inside buffers.
>
> bsm_notify.c: notify_check function on my Mac OS X 10.4.8 expects an int on 
> the second parameter, not an unsigned int.
>
> bsm_token.c: au_to_newgroups expect a gid_t* on the second parameter, not an 
> int*. In fact a gid_t may expand to an int or even an unsigned int.
>
> Instructions:
> $ cd openbsm
> $ patch -p1 < warnings.patch
>
> Please review.

Diego,

Sorry for the long delay in getting back to you on this.  I've installed gcc41 
on my desktop box, confirmed the warning fixes, and merged to Perforce.  These 
changes will appear starting in OpenBSM 1.0 alpha 14.

Thanks!

Robert N M Watson
Computer Laboratory
University of Cambridge


More information about the trustedbsd-audit mailing list