svn commit: r228809 - vendor/openpam/dist/lib

Gleb Smirnoff glebius at FreeBSD.org
Thu Dec 22 19:52:12 UTC 2011


On Thu, Dec 22, 2011 at 08:34:29PM +0100, Dag-Erling Sm??rgrav wrote:
D> > >  /*
D> > > @@ -124,7 +129,8 @@
D> > >  		dlclose(dlh);
D> > >  	FREE(module);
D> > >  err:
D> > > -	openpam_log(PAM_LOG_ERROR, "%m");
D> > > +	if (errno != 0)
D> > > +		openpam_log(PAM_LOG_ERROR, "%s: %m", path);
D> > >  	return (NULL);
D> > >  }
D> >
D> > I think vpath is better choice here, as explained in previous mail
D> 
D> At this point, vpath is either NULL or garbage.

Here is my variant attached.

It is silent on success, printing these on failure:

Dec 22 23:49:39 projcarp1 sshd[3208]: in openpam_dynamic(): /usr/local/lib/pam_ldap.so: No such file or directory
Dec 22 23:49:39 projcarp1 sshd[3208]: in openpam_load_module(): no /usr/local/lib/pam_ldap.so found

-- 
Totus tuus, Glebius.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpam_dynamic.c.diff
Type: text/x-diff
Size: 1231 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-vendor/attachments/20111222/eab144cb/openpam_dynamic.c.bin


More information about the svn-src-vendor mailing list