svn commit: r299818 - user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd

Gleb Smirnoff glebius at FreeBSD.org
Wed May 18 22:49:32 UTC 2016


On Sun, May 15, 2016 at 01:10:32AM +0000, Garrett Cooper wrote:
G> Author: ngie
G> Date: Sun May 15 01:10:31 2016
G> New Revision: 299818
G> URL: https://svnweb.freebsd.org/changeset/base/299818
G> 
G> Log:
G>   Test laddr.s_addr against NULL, not 0
G> 
G> Modified:
G>   user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c
G> 
G> Modified: user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c
G> ==============================================================================
G> --- user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c	Sun May 15 00:54:21 2016	(r299817)
G> +++ user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c	Sun May 15 01:10:31 2016	(r299818)
G> @@ -1220,7 +1220,7 @@ snmpd_input(struct port_input *pi, struc
G>  		
G>  		ret = recv_dgram(pi, &laddr);
G>  
G> -		if (laddr.s_addr == 0) {
G> +		if (laddr.s_addr == NULL) {
G>  			msg.msg_control = NULL;
G>  			msg.msg_controllen = 0;
G>  		}

This change also seems incorrect. It isn't a pointer.

-- 
Totus tuus, Glebius.


More information about the svn-src-user mailing list