svn commit: r212942 - user/weongyo/usb/sys/dev/usb

Weongyo Jeong weongyo at FreeBSD.org
Tue Sep 21 00:07:19 UTC 2010


Author: weongyo
Date: Tue Sep 21 00:07:18 2010
New Revision: 212942
URL: http://svn.freebsd.org/changeset/base/212942

Log:
  Adds XXX comments looking ambiguous.

Modified:
  user/weongyo/usb/sys/dev/usb/usb_busdma.c

Modified: user/weongyo/usb/sys/dev/usb/usb_busdma.c
==============================================================================
--- user/weongyo/usb/sys/dev/usb/usb_busdma.c	Tue Sep 21 00:06:19 2010	(r212941)
+++ user/weongyo/usb/sys/dev/usb/usb_busdma.c	Tue Sep 21 00:07:18 2010	(r212942)
@@ -913,6 +913,7 @@ usb_bdma_work_loop(struct usb_xfer_queue
 		 * the USB page caches.
 		 */
 		xfer->frbuffers[0].page_start = pg;
+		/* XXX why +2 here?  It looks it's a quirk */
 		xfer->frbuffers[0].npage = (frlength_0 / USB_PAGE_SIZE) + 2;
 
 		info->dma_nframes = nframes;
@@ -920,15 +921,18 @@ usb_bdma_work_loop(struct usb_xfer_queue
 		info->dma_frlength_0 = frlength_0;
 
 		pg += (frlength_0 / USB_PAGE_SIZE);
+		/* XXX why +2 here?  It looks it's a quirk */
 		pg += 2;
 
 		while (--nframes > 0) {
 			xfer->frbuffers[nframes].isread = isread;
 			xfer->frbuffers[nframes].page_start = pg;
+			/* XXX why +2 here?  It looks it's a quirk */
 			xfer->frbuffers[nframes].npage =
 			    (xfer->frlengths[nframes] / USB_PAGE_SIZE) + 2;
 
 			pg += (xfer->frlengths[nframes] / USB_PAGE_SIZE);
+			/* XXX why +2 here?  It looks it's a quirk */
 			pg += 2;
 		}
 


More information about the svn-src-user mailing list