svn commit: r212571 - user/weongyo/usb/sys/dev/usb/controller

Weongyo Jeong weongyo at FreeBSD.org
Mon Sep 13 18:32:50 UTC 2010


Author: weongyo
Date: Mon Sep 13 18:32:49 2010
New Revision: 212571
URL: http://svn.freebsd.org/changeset/base/212571

Log:
  Adds a XXX comment not sure that devclass_find(9) requires Giant
  holding.  Just looking the source code it looks it doesn't require it
  though it has a `devclasses' traversal loop.

Modified:
  user/weongyo/usb/sys/dev/usb/controller/usb_controller.c

Modified: user/weongyo/usb/sys/dev/usb/controller/usb_controller.c
==============================================================================
--- user/weongyo/usb/sys/dev/usb/controller/usb_controller.c	Mon Sep 13 18:26:34 2010	(r212570)
+++ user/weongyo/usb/sys/dev/usb/controller/usb_controller.c	Mon Sep 13 18:32:49 2010	(r212571)
@@ -394,6 +394,7 @@ usb_attach_sub(device_t dev, struct usb_
 {
 	const char *pname = device_get_nameunit(dev);
 
+	/* XXX devclass_find(9) needs Giant? */
 	GIANT_REQUIRED;
 	if (usb_devclass_ptr == NULL)
 		usb_devclass_ptr = devclass_find("usbus");


More information about the svn-src-user mailing list