svn commit: r213540 - user/weongyo/usb/sys/dev/usb/net
Julian Elischer
julian at freebsd.org
Mon Oct 11 16:45:03 UTC 2010
On 10/11/10 8:39 AM, Hans Petter Selasky wrote:
> On Friday 08 October 2010 03:52:01 Weongyo Jeong wrote:
>> Author: weongyo
>> Date: Fri Oct 8 01:52:01 2010
>> New Revision: 213540
>> URL: http://svn.freebsd.org/changeset/base/213540
>>
>> Log:
>> o fixes a regression that setting the promiscuous mode should be
>> happened at the taskqueue. It's to avoid a `sleepable after
>> non-sleepable' because ioctl handler could be called with holding bpf
>> mtx which is a default mutex.
>> o defines SLEEPOUT_DRAIN_TASK helper.
>>
[...]
> These taskqueues belong in the network stack and not the USB drivers! And
> please understand that you cannot use taskqueues for these commands, because
> the events can be executed out of order!!!
sounds like we should add an option to taskqueues to fix this then.
I'd rather fix the standard facility than make a new one.
> --HPS
>
More information about the svn-src-user
mailing list