svn commit: r187978 - user/thompsa/usb/sys/dev/usb2/ethernet

M. Warner Losh imp at bsdimp.com
Sun Feb 1 19:36:12 PST 2009


In message: <20090201213749.GJ32503 at citylink.fud.org.nz>
            Andrew Thompson <thompsa at FreeBSD.org> writes:
: On Sun, Feb 01, 2009 at 02:28:08PM -0700, M. Warner Losh wrote:
: > In message: <200902010650.n116obU1045871 at svn.freebsd.org>
: >             Andrew Thompson <thompsa at FreeBSD.org> writes:
: > : +	locked = mtx_owned(&sc->sc_mtx);
: > : +	if (!locked)
: > : +		AUE_LOCK(sc);
: > 
: > You do know this is racy, right?
: 
: Yea... It only get called unlocked during mii probe+attach so its fine.
: I havnt actaully checked if its ok to hold a mutex during
: mii_phy_probe() which would make this go away.

You hold GIANT when probe+attach, which means I think you can't
acquire any other locks...

Warner


More information about the svn-src-user mailing list