svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi...

[Kyle Evans]

On Wed, Mar 28, 2018 at 8:04 PM, Allan Jude <allanjude at freebsd.org> wrote:
> On 2018-03-28 14:15, Oliver Pinter wrote:
>> Hi!
>>
>> This part of the MFC is wrong:
>>
>> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897
>>
>> Could you please MFC back the other random related changes too? Some
>> of them made by cem at .
>>
>> On 3/14/18, Eitan Adler <eadler at freebsd.org> wrote:
>>> Author: eadler
>>> Date: Wed Mar 14 03:19:51 2018
>>> New Revision: 330897
>>> URL: https://svnweb.freebsd.org/changeset/base/330897
>>>
>>> Log:
>>>   Partial merge of the SPDX changes
>>>
>>>   These changes are incomplete but are making it difficult
>>>   to determine what other changes can/should be merged.
>>>
>>>   No objections from:        pfg
>>>
> Am I missing something? If this MFC was supposed to be of the SPDX
> license tagging, why does it have any functional changes?
>
> Especially changes to random(4)?

For extra fun, it also had some ARM driver changes that had broken the
VERSATILE kernels, as I recall. gonzo@ took care of MFC'ing the other
parts needed for those, though. It does make me wonder what else was
overlooked, but the commit was large enough that it's not fun to
glance over.