svn commit: r239561 - stable/8/sys/amd64/amd64

Konstantin Belousov kib at FreeBSD.org
Wed Aug 22 05:38:07 UTC 2012


Author: kib
Date: Wed Aug 22 05:38:06 2012
New Revision: 239561
URL: http://svn.freebsd.org/changeset/base/239561

Log:
  MFC r239125:
  Do not apply errata 721 workaround when under hypervisor, since
  typical hypervisor does not implement access to the required MSR,
  causing #GP on boot.

Modified:
  stable/8/sys/amd64/amd64/initcpu.c
Directory Properties:
  stable/8/sys/   (props changed)

Modified: stable/8/sys/amd64/amd64/initcpu.c
==============================================================================
--- stable/8/sys/amd64/amd64/initcpu.c	Wed Aug 22 05:36:10 2012	(r239560)
+++ stable/8/sys/amd64/amd64/initcpu.c	Wed Aug 22 05:38:06 2012	(r239561)
@@ -91,11 +91,17 @@ init_amd(void)
 	 *
 	 * http://support.amd.com/us/Processor_TechDocs/41322_10h_Rev_Gd.pdf
 	 * http://support.amd.com/us/Processor_TechDocs/44739_12h_Rev_Gd.pdf
+	 *
+	 * Hypervisors do not provide access to the errata MSR,
+	 * causing #GP exception on attempt to apply the errata.  The
+	 * MSR write shall be done on host and persist globally
+	 * anyway, so do not try to do it when under virtualization.
 	 */
 	switch (CPUID_TO_FAMILY(cpu_id)) {
 	case 0x10:
 	case 0x12:
-		wrmsr(0xc0011029, rdmsr(0xc0011029) | 1);
+		if ((cpu_feature2 & CPUID2_HV) == 0)
+			wrmsr(0xc0011029, rdmsr(0xc0011029) | 1);
 		break;
 	}
 }


More information about the svn-src-stable mailing list