Request for patch approval (Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys)

[Kostik Belousov]

On Sat, Sep 10, 2011 at 04:39:37PM +0200, Hans Petter Selasky wrote:
> On Saturday 10 September 2011 16:28:12 Kostik Belousov wrote:
> > On Sat, Sep 10, 2011 at 03:40:16PM +0200, Hans Petter Selasky wrote:
> > > > Right -- exactly my point. If this change breaks third-party compiled
> > > > USB device drivers, then our current approach to device driver KBIs
> > > > does not allow it to be MFC'd in this form. Are there ways you can
> > > > reformulate the change to avoid breaking those drivers? Sometimes this
> > > > can be done by adding new symbols, rather than replacing currently
> > > > symbols, although mileage varies.
> > > 
> > > Hi,
> > > 
> > > Here is my proposal:
> > > 
> > > Implement test for automatic quirks in function which has access to the
> > > USB device structure. This decouples the structure change in "struct
> > > usbd_lookup_info".
> > > 
> > > The only structure which needs change is "struct usb_device". In
> > > 9-current this structure will be kept as is. In 8-stable the new element
> > > will be moved to the end of the structure like suggested, and then there
> > > shouldn't be any problems.
> > > 
> > > Please find patches attached.
> > > 
> > > --HPS
> > > 
> > > Commit message:
> > > 
> > > Refactor auto-quirk solution so that we break as few external
> > > drivers as possible.
> > > 
> > > PR:             usb/160299
> > > Approved by:    re (kib)
> > > Suggested by:   rwatson
> > > MFC after:      0 days
> > 
> > First, can you, please, regenerate the diff for stable/8 against the
> > code before r225458 ? I want to read diff to see ABI change, assuming
> > r225458 was not done at all.
> > 
> > Second, you cannot decrement __FreeBSD_version. In fact, you shall
> > increment it once more in the patch for stable/8.
> 
> Ok.
> 
> Please find attached output from:
> 
> svn diff -r 225457 sys/

For me, it looks fine. Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-stable/attachments/20110910/38fa41b5/attachment.pgp