Request for patch approval (Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys)

[Hans Petter Selasky]

> Right -- exactly my point. If this change breaks third-party compiled USB
> device drivers, then our current approach to device driver KBIs does not
> allow it to be MFC'd in this form. Are there ways you can reformulate the
> change to avoid breaking those drivers? Sometimes this can be done by
> adding new symbols, rather than replacing currently symbols, although
> mileage varies.

Hi,

Here is my proposal:

Implement test for automatic quirks in function which has access to the USB 
device structure. This decouples the structure change in "struct 
usbd_lookup_info".

The only structure which needs change is "struct usb_device". In 9-current 
this structure will be kept as is. In 8-stable the new element will be moved 
to the end of the structure like suggested, and then there shouldn't be any 
problems.

Please find patches attached.

--HPS

Commit message:

Refactor auto-quirk solution so that we break as few external
drivers as possible.

PR:             usb/160299
Approved by:    re (kib)
Suggested by:   rwatson
MFC after:      0 days

-------------- next part --------------
A non-text attachment was scrubbed...
Name: msc_auto_quirk_8_stable.patch
Type: text/x-patch
Size: 4680 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-stable/attachments/20110910/e5fc636b/msc_auto_quirk_8_stable.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msc_auto_quirk_9_current.patch
Type: text/x-patch
Size: 3956 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-stable/attachments/20110910/e5fc636b/msc_auto_quirk_9_current.bin