svn commit: r203988 - stable/8/sys/kern

Konstantin Belousov kib at FreeBSD.org
Wed Feb 17 09:03:38 UTC 2010


Author: kib
Date: Wed Feb 17 09:03:38 2010
New Revision: 203988
URL: http://svn.freebsd.org/changeset/base/203988

Log:
  MFC r203875:
  Do not leak process lock when current thread is not allowed to see target.

Modified:
  stable/8/sys/kern/kern_event.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)
  stable/8/sys/netinet/   (props changed)

Modified: stable/8/sys/kern/kern_event.c
==============================================================================
--- stable/8/sys/kern/kern_event.c	Wed Feb 17 08:40:54 2010	(r203987)
+++ stable/8/sys/kern/kern_event.c	Wed Feb 17 09:03:38 2010	(r203988)
@@ -334,8 +334,10 @@ filt_procattach(struct knote *kn)
 
 	if (p == NULL)
 		return (ESRCH);
-	if ((error = p_cansee(curthread, p)))
+	if ((error = p_cansee(curthread, p))) {
+		PROC_UNLOCK(p);
 		return (error);
+	}
 
 	kn->kn_ptr.p_proc = p;
 	kn->kn_flags |= EV_CLEAR;		/* automatically set */


More information about the svn-src-stable mailing list