svn commit: r206312 - stable/8/sys/dev/usb/serial
Andrew Thompson
thompsa at FreeBSD.org
Tue Apr 6 23:25:20 UTC 2010
Author: thompsa
Date: Tue Apr 6 23:25:19 2010
New Revision: 206312
URL: http://svn.freebsd.org/changeset/base/206312
Log:
MFC r205031
It appears that some UVISOR devices do not handle when the clear stall command
is issued at the beginning of the initial IN/OUT data transfers. Reason
unknown, probably firmware fault. Now the stall is only cleared on data
transfer errors.
PR: usb/144199
Submitted by: Hans Petter Selasky
Modified:
stable/8/sys/dev/usb/serial/uvisor.c
Directory Properties:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
stable/8/sys/dev/xen/xenpci/ (props changed)
Modified: stable/8/sys/dev/usb/serial/uvisor.c
==============================================================================
--- stable/8/sys/dev/usb/serial/uvisor.c Tue Apr 6 23:24:55 2010 (r206311)
+++ stable/8/sys/dev/usb/serial/uvisor.c Tue Apr 6 23:25:19 2010 (r206312)
@@ -345,11 +345,6 @@ uvisor_attach(device_t dev)
DPRINTF("could not allocate all pipes\n");
goto detach;
}
- /* clear stall at first run */
- mtx_lock(&sc->sc_mtx);
- usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_WR]);
- usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_RD]);
- mtx_unlock(&sc->sc_mtx);
error = ucom_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
&uvisor_callback, &sc->sc_mtx);
More information about the svn-src-stable
mailing list