svn commit: r195696 - in stable/7: crypto/openssh secure/lib/libssh

[John Baldwin]

On Tuesday 21 July 2009 12:08:10 am David O'Brien wrote:
> On Tue, Jul 14, 2009 at 08:46:19PM +0000, John Baldwin wrote:
> > Date: Tue Jul 14 20:46:19 2009
> > New Revision: 195696
> > URL: http://svn.freebsd.org/changeset/base/195696
> > Log:
> >   MFC: Use the closefrom(2) system call.
> > Modified:
> >   stable/7/crypto/openssh/   (props changed)
> >   stable/7/crypto/openssh/config.h
> >   stable/7/crypto/openssh/ssh_namespace.h
> >   stable/7/secure/lib/libssh/   (props changed)
> >   stable/7/secure/lib/libssh/Makefile
> 
> Hi John,
> Would you mind backing out this commit from 7-stable.
> This change mades it so one cannot seriously boot a machine multiuser
> with an older kernel as /usr/sbin/sshd dies due to bad system call.  I
> think the MFC of this part of the closefrom(2) addtion edge up against
> POLA for a mature -stable branch.
> 
> Even in -CURRENT it's good form to add a new system call and then
> immedately use it... without some time laps to allow folks to boot
> a week old kernel.

Will do, no problem.

-- 
John Baldwin