svn commit: r200205 - stable/8/etc

[Doug Barton]

Hiroki Sato wrote:
> Author: hrs
> Date: Mon Dec  7 06:25:19 2009
> New Revision: 200205
> URL: http://svn.freebsd.org/changeset/base/200205
> 
> Log:
>   MFC:
>   
>   r197144:
>   - Add an extension of set_rcvar(), a new function set_rcvar_obsolete(),
>     and $desc.
>   
>     The set_rcvar_obsolete() is to mark a variable as obsolete and define
>     the new one.  More specifically, a warning is displayed when
>     a variable is removed or changed in the source tree and the user
>     still defines the old one.

> @@ -588,7 +616,7 @@ run_rc_command()
>  	esac
>  
>  	eval _override_command=\$${name}_program
> -	command=${_override_command:-$command}
> +	command=${command:-${_override_command}}
>  
>  	_keywords="start stop restart rcvar $extra_commands"
>  	rc_pid=

Hiroki,

You apparently merged your change from r197144 without applying my fix
for this problem above from r198162, which broke this feature in
8-stable. See http://www.freebsd.org/cgi/query-pr.cgi?pr=141642

In my mind breaking this feature in a -stable branch is a fairly
serious error, and adds fuel to my growing discomfort about the
changes you've been making in /etc. How do you suggest that we move
forward and at the same time lessen the potential for further problems?


Doug

-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/