svn commit: r196171 - stable/7/sys/netsmb

Robert Watson rwatson at FreeBSD.org
Thu Aug 13 08:36:11 UTC 2009


On Thu, 13 Aug 2009, Nick Hibma wrote:

>  Silence this module.

I can't help but notice you're committing changes to a stable branch without 
first making them in head.  For the USB stack, where there's a different 
implementation between head and stable/7, that's fine.  For code that's 
shared, it's really not fine.  Please stop.

Robert N M Watson
Computer Laboratory
University of Cambridge

>
> Modified:
>  stable/7/sys/netsmb/smb_dev.c
>
> Modified: stable/7/sys/netsmb/smb_dev.c
> ==============================================================================
> --- stable/7/sys/netsmb/smb_dev.c	Thu Aug 13 08:24:58 2009	(r196170)
> +++ stable/7/sys/netsmb/smb_dev.c	Thu Aug 13 08:31:15 2009	(r196171)
> @@ -341,7 +341,6 @@ nsmb_dev_load(module_t mod, int cmd, voi
> 			break;
> 		}
> 		nsmb_dev_tag = EVENTHANDLER_REGISTER(dev_clone, nsmb_dev_clone, 0, 1000);
> -		printf("netsmb_dev: loaded\n");
> 		break;
> 	    case MOD_UNLOAD:
> 		smb_iod_done();
> @@ -351,7 +350,6 @@ nsmb_dev_load(module_t mod, int cmd, voi
> 		EVENTHANDLER_DEREGISTER(dev_clone, nsmb_dev_tag);
> 		drain_dev_clone_events();
> 		destroy_dev_drain(&nsmb_cdevsw);
> -		printf("netsmb_dev: unloaded\n");
> 		break;
> 	    default:
> 		error = EINVAL;
>


More information about the svn-src-stable mailing list