svn commit: r296146 - stable/9/sys/dev/filemon

Slawa Olhovchenkov slw at zxy.spb.ru
Sun Feb 28 12:37:26 UTC 2016


On Sun, Feb 28, 2016 at 12:20:09PM +0000, Brooks Davis wrote:

> On Sun, Feb 28, 2016 at 01:27:28PM +0300, Slawa Olhovchenkov wrote:
> > On Sat, Feb 27, 2016 at 08:57:34PM +0000, Bryan Drewery wrote:
> > 
> > > Author: bdrewery
> > > Date: Sat Feb 27 20:57:34 2016
> > > New Revision: 296146
> > > URL: https://svnweb.freebsd.org/changeset/base/296146
> > > 
> > > Log:
> > >   MFC r242088:
> > >   
> > >     Desupport pre-FreeBSD 7.1.
> > > 
> > > Modified:
> > >   stable/9/sys/dev/filemon/filemon.c
> > > Directory Properties:
> > >   stable/9/sys/   (props changed)
> > >   stable/9/sys/dev/   (props changed)
> > > -#if __FreeBSD_version < 701000
> > 
> > Not specialy to this commit, just for information: what purpose to
> > have in src tree, already divided to branches, pieces of code under
> > #if?
> > 
> > Of couse, question not about external maintained code.
> 
> Filemon started as externally maintained code and initially it was
> a bit ambiguous which direction changes would flow.

I.e. historical behaviour.

> Sometimes it's also useful to allow code in HEAD to just work when
> copied to stable so people can see if their problem is fixed without
> having to merge too much.

Please, check me: in mostly cases this is equivalent of MFC in one
commit (and have same complexity as MFC) but w/o actualy MFC.

> In general though, we should remove code like
> this in things maintained entirely in tree.

Thanks!



More information about the svn-src-stable-9 mailing list