svn commit: r266250 - stable/8/lib/libc/rpc

Christian Brueffer brueffer at FreeBSD.org
Fri May 16 15:56:08 UTC 2014


Author: brueffer
Date: Fri May 16 15:56:07 2014
New Revision: 266250
URL: http://svnweb.freebsd.org/changeset/base/266250

Log:
  MFC: r265238
  
  Properly free resources in case of error.
  
  CID:		1007032
  Found with:	Coverity Prevent(tm)

Modified:
  stable/8/lib/libc/rpc/clnt_vc.c
Directory Properties:
  stable/8/lib/libc/   (props changed)
  stable/8/lib/libc/rpc/   (props changed)

Modified: stable/8/lib/libc/rpc/clnt_vc.c
==============================================================================
--- stable/8/lib/libc/rpc/clnt_vc.c	Fri May 16 15:53:47 2014	(r266249)
+++ stable/8/lib/libc/rpc/clnt_vc.c	Fri May 16 15:56:07 2014	(r266250)
@@ -302,15 +302,13 @@ clnt_vc_create(fd, raddr, prog, vers, se
 	return (cl);
 
 err:
-	if (cl) {
-		if (ct) {
-			if (ct->ct_addr.len)
-				mem_free(ct->ct_addr.buf, ct->ct_addr.len);
-			mem_free(ct, sizeof (struct ct_data));
-		}
-		if (cl)
-			mem_free(cl, sizeof (CLIENT));
+	if (ct) {
+		if (ct->ct_addr.len)
+			mem_free(ct->ct_addr.buf, ct->ct_addr.len);
+		mem_free(ct, sizeof (struct ct_data));
 	}
+	if (cl)
+		mem_free(cl, sizeof (CLIENT));
 	return ((CLIENT *)NULL);
 }
 


More information about the svn-src-stable-8 mailing list