svn commit: r235867 - in stable/8: lib/libusbhid sys/dev/usb

Alexander Motin mav at FreeBSD.org
Thu May 24 01:24:50 UTC 2012


Author: mav
Date: Thu May 24 01:24:49 2012
New Revision: 235867
URL: http://svn.freebsd.org/changeset/base/235867

Log:
  MFC r235510:
  HID Report ID is unsigned value, so clear the rest of bits from possible
  sign expansion.

Modified:
  stable/8/lib/libusbhid/parse.c
  stable/8/sys/dev/usb/usb_hid.c
Directory Properties:
  stable/8/lib/libusbhid/   (props changed)
  stable/8/sys/   (props changed)

Modified: stable/8/lib/libusbhid/parse.c
==============================================================================
--- stable/8/lib/libusbhid/parse.c	Thu May 24 01:23:30 2012	(r235866)
+++ stable/8/lib/libusbhid/parse.c	Thu May 24 01:24:49 2012	(r235867)
@@ -392,7 +392,7 @@ hid_get_item(hid_data_t s, hid_item_t *h
 				s->loc_size = dval & mask;
 				break;
 			case 8:
-				hid_switch_rid(s, c, dval);
+				hid_switch_rid(s, c, dval & mask);
 				break;
 			case 9:
 				/* mask because value is unsigned */

Modified: stable/8/sys/dev/usb/usb_hid.c
==============================================================================
--- stable/8/sys/dev/usb/usb_hid.c	Thu May 24 01:23:30 2012	(r235866)
+++ stable/8/sys/dev/usb/usb_hid.c	Thu May 24 01:24:49 2012	(r235867)
@@ -425,7 +425,7 @@ hid_get_item(struct hid_data *s, struct 
 				s->loc_size = dval & mask;
 				break;
 			case 8:
-				hid_switch_rid(s, c, dval);
+				hid_switch_rid(s, c, dval & mask);
 				break;
 			case 9:
 				/* mask because value is unsigned */


More information about the svn-src-stable-8 mailing list