svn commit: r235650 - stable/8/usr.sbin/mfiutil

Andriy Gapon avg at FreeBSD.org
Sat May 19 19:47:02 UTC 2012


on 19/05/2012 22:34 Bjoern A. Zeeb said the following:
> 
> On 19. May 2012, at 18:57 , Andriy Gapon wrote:
> 
>> on 19/05/2012 17:32 Bjoern A. Zeeb said the following:
>>> Author: bz
>>> Date: Sat May 19 14:32:47 2012
>>> New Revision: 235650
>>> URL: http://svn.freebsd.org/changeset/base/235650
>>>
>>> Log:
>>>  MFC r233713:
[snip]
>>>  To unbreak the build after:	r235625 (?)
> 
> 
> ..
>>> @@ -211,9 +211,8 @@ clear_config(int ac, char **av)
>>> }
>>> MFI_COMMAND(top, clear, clear_config);
>>>
>>> -#define	MFI_ARRAY_SIZE		288
>>> -#define	MAX_DRIVES_PER_ARRAY						\
>>> -	((MFI_ARRAY_SIZE - sizeof(struct mfi_array)) / 8)
>>> +#define MAX_DRIVES_PER_ARRAY MFI_MAX_ROW_SIZE
>>> +#define MFI_ARRAY_SIZE sizeof(struct mfi_array)
>>
>> A small nit: previously MFI_ARRAY_SIZE wasn't used for anything except
>> MAX_DRIVES_PER_ARRAY, now it's not used for anything.
> 
> Whatever else needs to be fixed in HEAD or MFCed to stable I don't know;
> see the last line of my commit message and talk to the other suspects like
> jhb, sbruno, ambrisko, emaste....
> 

I actually missed the first line, that is the fact that it was an MFC.
Somehow I mistook it for a direct commit to fix the build.

-- 
Andriy Gapon


More information about the svn-src-stable-8 mailing list