svn commit: r223119 - stable/8/sys/kern

Mikolaj Golub trociny at
Wed Jun 15 20:34:41 UTC 2011

Author: trociny
Date: Wed Jun 15 20:34:40 2011
New Revision: 223119

  MFC r222454:
  In soreceive_generic(), if MSG_WAITALL is set but the request is
  larger than the receive buffer, we have to receive in sections.
  When notifying the protocol that some data has been drained the
  lock is released for a moment. Returning we block waiting for the
  rest of data. There is a race, when data could arrive while the
  lock was released and then the connection stalls in sbwait.
  Fix this by checking for data before blocking and skip blocking
  if there are some.
  PR:		kern/154504
  Reported by:	Andrey Simonenko <simon at>
  Tested by:	Andrey Simonenko <simon at>
  Reviewed by:	rwatson
  Approved by:	pjd (mentor)

Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/kern/uipc_socket.c
--- stable/8/sys/kern/uipc_socket.c	Wed Jun 15 19:53:08 2011	(r223118)
+++ stable/8/sys/kern/uipc_socket.c	Wed Jun 15 20:34:40 2011	(r223119)
@@ -1836,10 +1836,16 @@ dontblock:
-			error = sbwait(&so->so_rcv);
-			if (error) {
-				SOCKBUF_UNLOCK(&so->so_rcv);
-				goto release;
+			/*
+			 * We could receive some data while was notifying
+			 * the protocol. Skip blocking in this case.
+			 */
+			if (so->so_rcv.sb_mb == NULL) {
+				error = sbwait(&so->so_rcv);
+				if (error) {
+					SOCKBUF_UNLOCK(&so->so_rcv);
+					goto release;
+				}
 			m = so->so_rcv.sb_mb;
 			if (m != NULL)

More information about the svn-src-stable-8 mailing list