svn commit: r229022 - stable/8/sys/fs/procfs

Konstantin Belousov kib at FreeBSD.org
Fri Dec 30 20:24:53 UTC 2011


Author: kib
Date: Fri Dec 30 20:24:52 2011
New Revision: 229022
URL: http://svn.freebsd.org/changeset/base/229022

Log:
  MFC r227393:
  Lock the thread lock around block that retrieves td_wmesg. Otherwise,
  procfs could see a thread with assigned td_wchan but still NULL td_wmesg.

Modified:
  stable/8/sys/fs/procfs/procfs_status.c
Directory Properties:
  stable/8/sys/   (props changed)

Modified: stable/8/sys/fs/procfs/procfs_status.c
==============================================================================
--- stable/8/sys/fs/procfs/procfs_status.c	Fri Dec 30 20:21:53 2011	(r229021)
+++ stable/8/sys/fs/procfs/procfs_status.c	Fri Dec 30 20:24:52 2011	(r229022)
@@ -113,12 +113,14 @@ procfs_doprocstatus(PFS_FILL_ARGS)
 	}
 
 	tdfirst = FIRST_THREAD_IN_PROC(p);
+	thread_lock(tdfirst);
 	if (tdfirst->td_wchan != NULL) {
 		KASSERT(tdfirst->td_wmesg != NULL,
 		    ("wchan %p has no wmesg", tdfirst->td_wchan));
 		wmesg = tdfirst->td_wmesg;
 	} else
 		wmesg = "nochan";
+	thread_unlock(tdfirst);
 
 	if (p->p_flag & P_INMEM) {
 		struct timeval start, ut, st;


More information about the svn-src-stable-8 mailing list