svn commit: r218871 - stable/7/sys/dev/alc

Pyun YongHyeon yongari at FreeBSD.org
Sun Feb 20 01:17:00 UTC 2011


Author: yongari
Date: Sun Feb 20 01:16:59 2011
New Revision: 218871
URL: http://svn.freebsd.org/changeset/base/218871

Log:
  MFC r218141:
    alc_rev was used without initialization such that it failed to
    apply AR8152 v1.0 specific initialization code. Fix this bug by
    explicitly reading PCI device revision id via PCI accessor.
  
    Reported by:	Gabriel Linder ( linder.gabriel <> gmail dot com )

Modified:
  stable/7/sys/dev/alc/if_alc.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/dev/alc/if_alc.c
==============================================================================
--- stable/7/sys/dev/alc/if_alc.c	Sun Feb 20 01:15:26 2011	(r218870)
+++ stable/7/sys/dev/alc/if_alc.c	Sun Feb 20 01:16:59 2011	(r218871)
@@ -810,7 +810,7 @@ alc_attach(device_t dev)
 		    CSR_READ_4(sc, ALC_PCIE_PHYMISC) |
 		    PCIE_PHYMISC_FORCE_RCV_DET);
 		if (sc->alc_ident->deviceid == DEVICEID_ATHEROS_AR8152_B &&
-		    sc->alc_rev == ATHEROS_AR8152_B_V10) {
+		    pci_get_revid(dev) == ATHEROS_AR8152_B_V10) {
 			val = CSR_READ_4(sc, ALC_PCIE_PHYMISC2);
 			val &= ~(PCIE_PHYMISC2_SERDES_CDR_MASK |
 			    PCIE_PHYMISC2_SERDES_TH_MASK);


More information about the svn-src-stable-7 mailing list